Closed Bug 1135743 Opened 10 years ago Closed 10 years ago

Update details Filter jobs title, since it no longer opens in a new tab

Categories

(Tree Management :: Treeherder, defect)

Product:
Tree Management
Component:
Treeherder
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

References

(
URL
)

Details

Attachments

(2 files)

filterTipCurrent.png
77.99 KB, image/png
Details
treeherder-ui-PR383
49 bytes, text/x-github-pull-request
jfrench
: review+
Details | Review
I happened across this during smoke testing for the upcoming prod push. Since we no longer open the filter result in a new tab, I pose we change from: "Filter jobs like these in a new tab" to "Filter by this job type"
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Attached image filterTipCurrent.png —
Current appearance and location, pre-change.
Actually my proposed wording is a bit ambiguous. I will try to add some clarity w.r.t the platform-part of the filter.
Attached file treeherder-ui-PR383 —
I ended up just removing the reference to opening in a new tab. The remaining wording seems clear and direct.
Attachment #8568062 - Flags: review?(emorley)
Comment on attachment 8568062 [details] [review] treeherder-ui-PR383 Ed has r+'d this in the PR, so marking as such.
Attachment #8568062 - Flags: review?(emorley) → review+
Marking Fixed per above merge. I will verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified fixed on stage and prod.
Status: RESOLVED → VERIFIED
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/f3ab3bd6e824bcd96669dbdf1d8bae2e24a3d22a Bug 1135743 - Update job details Filter job title https://github.com/mozilla/treeherder/commit/e5a02f78f12b3c63787029c5e36deffb30581af5 Merge pull request #383 from tojonmz/bug-1135743 Bug 1135743 - Update job details Filter job title
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: