1135747 - [RTL][Contacts] The large central letter icons do not appear when navigating / pressing on the quicksearch side-bar in the list of contacts.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150223_1009.txt

Description:
In the contacts app there is a list of letters descending down the side of the screen. This is the quicksearch bar and the user can use it to navigate to a certain area of the contacts. This is particularly useful for large contacts list. The sidebar is very small and difficult to navigate so when pressing on the sidebar a large icon appears central-screen indicating the letter of the area of the sidebar currently being pressed (to assist in navigation / use). These icons do not appear when in RTL.

Repro Steps:
1) Update a Flame to 20150223010224
2) Launch Contacts app and import or create several contacts
3) Use the side-bar / quicksearch bar by scrolling up and down on it

Actual:
Large associated alphabet icon does not appear.

Expected:
Large letter icons will appear as the sidebar is navigated / used

Environmental Variables:
Device: Flame 3.0
Build ID: 20150223010224
Gaia: a6881205deae450757a8d1e1ed65e5e5be0ec633
Gecko: 86d2bb8bb1c9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 7/7
See attached: logcat, video: http://youtu.be/UmYQ6evIJ78

Comment 1

[Joshua Mitchell (Inactive)]

This issue does not occur in 2.2

Actual results: The large central letters appears when scrolling the quicksearch bar

Notes: The quicksearch bar is on the left side of the screen instead of the right as in 3.0 so what ever patch moved the quicksearch bar back over to the right side (per design due to right-handedness) *might* be responsible for this issue.

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional regression of a supported feature.

Requesting a window.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

Comment 1's assumption is correct.

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20150219204401
Gaia: e4f7c67378e33e83f88d38ddb4a6c2cabf1423c3
Gecko: 1b4c5daa7b7a
Version: 38.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20150220053248
Gaia: 9ae9b1410296db55d25e50c3afa63720ff691256
Gecko: dff32a7c1524
Version: 38.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working Gaia & First Broken Gecko - issue does NOT repro
Gaia: e4f7c67378e33e83f88d38ddb4a6c2cabf1423c3
Gecko: dff32a7c1524

Last Working Gecko & First Broken Gaia - issue DOES repro
Gaia: 9ae9b1410296db55d25e50c3afa63720ff691256
Gecko: 1b4c5daa7b7a

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/e4f7c67378e33e83f88d38ddb4a6c2cabf1423c3...9ae9b1410296db55d25e50c3afa63720ff691256

Caused by the patch for Bug 1134306.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Augustin, can you take a look at this please? Looks like the landing for bug 1134306 might have caused this to occur.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] autra:bug-1135747 > mozilla-b2g:master

Comment 6

[Augustin Trancart [:autra]]

Comment on attachment 8568196 [details] [review]
[gaia] autra:bug-1135747 > mozilla-b2g:master

Yes I forgot to overload a shared CSS rule for the contact scrollbar, sorry!

Jose, could you have a look at this? Especially, I didn't overload the html[dir="rtl"] nav[data-type="scrollbar"] p img  of scrolling.css in shared style, I didn't think it is used in contact list scrollbar. What do you think about that?

Comment 7

[Jose Manuel Cantera]

Comment on attachment 8568196 [details] [review]
[gaia] autra:bug-1135747 > mozilla-b2g:master

LGTM

thanks

Comment 8

[Johan Lorenzo [:jlorenzo]]

Bug 1134306 has been uplifted to 2.2, 7 hours ago.

Comment 9

[Johan Lorenzo [:jlorenzo]]

Triage: Broken functionality while in RTL mode, which is a feature for 2.2.

Comment 10

[Joshua Mitchell (Inactive)]

Johan - that does not make it 'not-a-regression'

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a7ee59c7d71b8e3900fc4be45f98f4fcd165df51

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8568196 [details] [review]
[gaia] autra:bug-1135747 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
RTL
[User impact] if declined:
Bad user experience
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
Low
[String changes made]:
None

Comment 13

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Flame 3.0 nightly. The selected letter's icon appears in center of screen when using on the quick search side bar.

Device: Flame 3.0 Master (full flash 319MB)
BuildID: 20150225010244
Gaia: f6bfd854fe4746f21bc006eac145365e85f98808
Gecko: 0a8b3b67715a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Adding verifyme keyword for verifying on 2.2 after uplifting.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/2133d73269b27c410b01b55286e785d22e065e2a

Comment 15

[Sue]

Attachment: verify_pass.png

This issue has been verified as "Pass" on latest build of Flame 2.2 and Nexus5 2.2/3.0 by STR in comment 0.
Result: The selected letter's icon appears in center of screen when using on the quick search side bar.
See attachment: verify_pass.png
Rate:0/5

Device: Flame 2.2 (pass)
Build ID               20150617002504
Gaia Revision          3414b07dc489976bf510fd8042c0af3b1192c160
Gaia Date              2015-06-16 22:04:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a2db74491088
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150617.040422
Firmware Date          Wed Jun 17 04:04:34 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (pass)
Build ID               20150617002504
Gaia Revision          3414b07dc489976bf510fd8042c0af3b1192c160
Gaia Date              2015-06-16 22:04:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a2db74491088
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150617.042332
Firmware Date          Wed Jun 17 04:24:07 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (pass)
Build ID               20150617160207
Gaia Revision          b404c41c5471c31610e64defb74ec066b411e724
Gaia Date              2015-06-17 17:01:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a3f280b6f8d5
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150617.192258
Firmware Date          Wed Jun 17 19:23:17 EDT 2015
Bootloader             HHZ12f