TelemetrySend: add test coverage for the submission path.

RESOLVED FIXED in Firefox 67

Status

()

P4
normal
RESOLVED FIXED
4 years ago
a month ago

People

(Reporter: Dexter, Assigned: danielleleb12, Mentored)

Tracking

Trunk
mozilla67
Points:
1

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [measurement:client][lang=js][good next bug])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
TelemetryPing.jsm builds a submission URL based on some of the information in the ping. We need to add test coverage for this in test_TelemetryPing.js.
(Reporter)

Updated

4 years ago
Blocks: 1120356
Blocks: 1122482
No longer blocks: 1120356
Blocks: 1201022
No longer blocks: 1122482
(Reporter)

Comment 1

4 years ago
This test should be added to test_TelemetrySend.js. We should also consider moving the version check from [1] to the newly added test.

[1] - https://dxr.mozilla.org/mozilla-central/rev/605de27d4e7f530159842649c02075c578d7a4a5/toolkit/components/telemetry/tests/unit/test_TelemetryController.js#140
Points: --- → 1
Priority: -- → P3
Whiteboard: [measurement:client]
(Reporter)

Updated

3 years ago
Blocks: 1137262
No longer blocks: 1201022
Priority: P3 → P4
Summary: TelemetryPing: add test coverage for the submission path. → TelemetrySend: add test coverage for the submission path.
Component: Client: Desktop → Telemetry
Product: Firefox Health Report → Toolkit

Comment 2

3 months ago
I think we now test this?
Flags: needinfo?(alessio.placitelli)
(Reporter)

Comment 3

3 months ago
(In reply to Chris H-C :chutten from comment #2)
> I think we now test this?

Weirdly enough, I don't think we do yet. We have the same test from comment 1 (https://searchfox.org/mozilla-central/rev/2e5e28f518524f8af5b158ddb605022b6a2d68cf/toolkit/components/telemetry/tests/unit/test_TelemetryController.js#130), but nothing making sure the submission URL is as we expect. I'll morph this to a mentored bug. Leaving the ni? around as a reminder :)
(Reporter)

Comment 4

2 months ago

Hey Jan-Erik, would you mind setting this up as mentored?

Flags: needinfo?(alessio.placitelli) → needinfo?(jrediger)
Mentor: jrediger, alessio.placitelli
Flags: needinfo?(jrediger)
Whiteboard: [measurement:client] → [measurement:client][lang=js][good next bug]

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
  3. Start working on this bug.
    • Open a new test to test_TelemetrySend.js
    • Start a PingServer (PingServer.start())
    • Send a ping. You can copy the sendPing function from test_TelemetryController.js
    • Fetch the request from the server: let request = await PingServer.promiseNextRequest()
    • Get the payload: let ping = decodeRequestPayload(request); checkPingFormat(ping, TEST_PING_TYPE, false, false);
    • Ensure that the URL from the request matches the path components as expected. See TelemetrySend for the list.
    • Also move the query string test from test_TelemetryController.js into this new test.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC (https://wiki.mozilla.org/Irc) most hours of most days.
  4. Build your change with mach build and test your change with mach test toolkit/components/telemetry/tests/unit/test_TelemetrySend.js. Also check your changes for adherence to our style guidelines by using mach lint
  5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
(Assignee)

Comment 6

2 months ago

Hi, I would like to do this bug if it's still available.

It is! Assigning it to you, let me know how it goes and don't refrain from asking if you get stuck.

Assignee: nobody → danielleleb12

Comment 9

a month ago
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8114eb631de
Adds test coverage for submission path. r=janerik

Backed out changeset d8114eb631de (bug 1135759) for xpcshell failures in toolkit/components/telemetry/tests/unit/test_TelemetrySend.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=227868342&repo=autoland&lineNumber=2227

INFO - TEST-START | toolkit/components/url-classifier/tests/unit/test_listmanager.js
[task 2019-02-12T09:32:45.422Z] 09:32:45 INFO - TEST-PASS | toolkit/components/url-classifier/tests/unit/test_listmanager.js | took 1318ms
[task 2019-02-12T09:32:45.438Z] 09:32:45 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_TelemetrySend.js
[task 2019-02-12T09:37:45.441Z] 09:37:45 WARNING - TEST-UNEXPECTED-TIMEOUT | toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | Test timed out
[task 2019-02-12T09:37:45.443Z] 09:37:45 INFO - TEST-INFO took 300000ms
[task 2019-02-12T09:37:45.443Z] 09:37:45 INFO - >>>>>>>
[task 2019-02-12T09:37:45.444Z] 09:37:45 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-02-12T09:37:45.445Z] 09:37:45 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2019-02-12T09:37:45.454Z] 09:37:45 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-02-12T09:37:45.454Z] 09:37:45 INFO - running event loop
[task 2019-02-12T09:37:45.454Z] 09:37:45 INFO - toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | Starting test_setup
[task 2019-02-12T09:37:45.454Z] 09:37:45 INFO - (xpcshell/head.js) | test test_setup pending (2)
[task 2019-02-12T09:37:45.456Z] 09:37:45 INFO - PID 16321 | JavaScript strict warning: resource://testing-common/AddonTestUtils.jsm, line 278: ReferenceError: reference to undefined property "testScope"
[task 2019-02-12T09:37:45.456Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "testScope"" {file: "resource://testing-common/AddonTestUtils.jsm" line: 278}]"
[task 2019-02-12T09:37:45.456Z] 09:37:45 INFO - PID 16321 | 1549963965629 addons.manager DEBUG Application has been upgraded
[task 2019-02-12T09:37:45.457Z] 09:37:45 INFO - PID 16321 | 1549963965646 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider", "XPIInternal"]
[task 2019-02-12T09:37:45.457Z] 09:37:45 INFO - PID 16321 | 1549963965650 addons.manager DEBUG Loaded provider scope for resource://gre/modules/LightweightThemeManager.jsm: ["LightweightThemeManager"]
[task 2019-02-12T09:37:45.458Z] 09:37:45 INFO - PID 16321 | 1549963965654 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm
[task 2019-02-12T09:37:45.459Z] 09:37:45 INFO - PID 16321 | 1549963965656 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/PluginProvider.jsm
[task 2019-02-12T09:37:45.459Z] 09:37:45 INFO - PID 16321 | 1549963965657 addons.manager DEBUG Starting provider: XPIProvider
[task 2019-02-12T09:37:45.460Z] 09:37:45 INFO - PID 16321 | 1549963965657 addons.xpi DEBUG startup
[task 2019-02-12T09:37:45.460Z] 09:37:45 INFO - PID 16321 | 1549963965658 addons.xpi INFO SystemAddonLocation directory is missing
[task 2019-02-12T09:37:45.461Z] 09:37:45 INFO - PID 16321 | 1549963965668 addons.xpi INFO Removing all system add-on upgrades.
[task 2019-02-12T09:37:45.462Z] 09:37:45 INFO - PID 16321 | 1549963965669 addons.xpi DEBUG checkForChanges
[task 2019-02-12T09:37:45.462Z] 09:37:45 INFO - PID 16321 | 1549963965669 addons.xpi DEBUG Loaded add-on state: ${}
[task 2019-02-12T09:37:45.463Z] 09:37:45 INFO - PID 16321 | 1549963965670 addons.xpi DEBUG New add-on tel-system-xpi@tests.mozilla.org in app-system-defaults
[task 2019-02-12T09:37:45.463Z] 09:37:45 INFO - PID 16321 | JavaScript strict warning: resource://gre/modules/addons/XPIProvider.jsm, line 554: ReferenceError: reference to undefined property "version"
[task 2019-02-12T09:37:45.464Z] 09:37:45 INFO - PID 16321 | JavaScript strict warning: resource://gre/modules/addons/XPIProvider.jsm, line 450: ReferenceError: reference to undefined property "currentModifiedTime"
[task 2019-02-12T09:37:45.465Z] 09:37:45 INFO - PID 16321 | 1549963965671 addons.xpi WARN Can't get modified time of /tmp/xpc-profile-4Ia8jx/sysfeatures/app0/tel-system-xpi@tests.mozilla.org.xpi
[task 2019-02-12T09:37:45.465Z] 09:37:45 INFO - PID 16321 | 1549963965672 addons.xpi DEBUG scanForChanges changed: true, state: {}
[task 2019-02-12T09:37:45.466Z] 09:37:45 INFO - PID 16321 | 1549963965680 addons.xpi-utils DEBUG Error: Synchronously loading the add-ons database(resource://gre/modules/addons/XPIDatabase.jsm:1293:15) JS Stack trace: syncLoadDB@XPIDatabase.jsm:1293:15
[task 2019-02-12T09:37:45.468Z] 09:37:45 INFO - PID 16321 | checkForChanges@XPIProvider.jsm:2638:9
[task 2019-02-12T09:37:45.468Z] 09:37:45 INFO - PID 16321 | startup@XPIProvider.jsm:2224:7
[task 2019-02-12T09:37:45.476Z] 09:37:45 INFO - PID 16321 | callProvider@AddonManager.jsm:204:12
[task 2019-02-12T09:37:45.476Z] 09:37:45 INFO - PID 16321 | _startProvider@AddonManager.jsm:653:5
[task 2019-02-12T09:37:45.476Z] 09:37:45 INFO - PID 16321 | startup@AddonManager.jsm:806:9
[task 2019-02-12T09:37:45.476Z] 09:37:45 INFO - PID 16321 | startup@AddonManager.jsm:2788:5
[task 2019-02-12T09:37:45.476Z] 09:37:45 INFO - PID 16321 | observe@addonManager.js:66:9
[task 2019-02-12T09:37:45.477Z] 09:37:45 INFO - PID 16321 | promiseStartupManager@AddonTestUtils.jsm:743:5
[task 2019-02-12T09:37:45.478Z] 09:37:45 INFO - PID 16321 | AsyncloadAddonManager@head.js:248:10
[task 2019-02-12T09:37:45.479Z] 09:37:45 INFO - PID 16321 | test_setup@test_TelemetrySend.js:103:3
[task 2019-02-12T09:37:45.479Z] 09:37:45 INFO - PID 16321 | async
run_next_test/_run_next_test/<@head.js:1435:22
[task 2019-02-12T09:37:45.480Z] 09:37:45 INFO - PID 16321 | async*_run_next_test@head.js:1435:10
[task 2019-02-12T09:37:45.480Z] 09:37:45 INFO - PID 16321 | run@head.js:686:9
[task 2019-02-12T09:37:45.481Z] 09:37:45 INFO - PID 16321 | _do_main@head.js:224:3
[task 2019-02-12T09:37:45.482Z] 09:37:45 INFO - PID 16321 | _execute_test@head.js:527:5
[task 2019-02-12T09:37:45.482Z] 09:37:45 INFO - PID 16321 | @-e:1:1
[task 2019-02-12T09:37:45.485Z] 09:37:45 INFO - PID 16321 | 1549963965681 addons.xpi-utils DEBUG Starting async load of XPI database /tmp/xpc-profile-4Ia8jx/extensions.json
[task 2019-02-12T09:37:45.485Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965629 addons.manager DEBUG Application has been upgraded"
[task 2019-02-12T09:37:45.486Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965646 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider", "XPIInternal"]"
[task 2019-02-12T09:37:45.487Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965650 addons.manager DEBUG Loaded provider scope for resource://gre/modules/LightweightThemeManager.jsm: ["LightweightThemeManager"]"
[task 2019-02-12T09:37:45.488Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965654 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm"
[task 2019-02-12T09:37:45.488Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965656 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/PluginProvider.jsm"
[task 2019-02-12T09:37:45.489Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965657 addons.manager DEBUG Starting provider: XPIProvider"
[task 2019-02-12T09:37:45.491Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965657 addons.xpi DEBUG startup"
[task 2019-02-12T09:37:45.492Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965658 addons.xpi INFO SystemAddonLocation directory is missing"
[task 2019-02-12T09:37:45.492Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965668 addons.xpi INFO Removing all system add-on upgrades."
[task 2019-02-12T09:37:45.494Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965669 addons.xpi DEBUG checkForChanges"
[task 2019-02-12T09:37:45.495Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965669 addons.xpi DEBUG Loaded add-on state: ${}"
[task 2019-02-12T09:37:45.496Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965670 addons.xpi DEBUG New add-on tel-system-xpi@tests.mozilla.org in app-system-defaults"
[task 2019-02-12T09:37:45.497Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "version"" {file: "resource://gre/modules/addons/XPIProvider.jsm" line: 554}]"
[task 2019-02-12T09:37:45.498Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "currentModifiedTime"" {file: "resource://gre/modules/addons/XPIProvider.jsm" line: 450}]"
[task 2019-02-12T09:37:45.499Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965671 addons.xpi WARN Can't get modified time of /tmp/xpc-profile-4Ia8jx/sysfeatures/app0/tel-system-xpi@tests.mozilla.org.xpi"
[task 2019-02-12T09:37:45.500Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965672 addons.xpi DEBUG scanForChanges changed: true, state: {}"
[task 2019-02-12T09:37:45.504Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965680 addons.xpi-utils DEBUG Error: Synchronously loading the add-ons database(resource://gre/modules/addons/XPIDatabase.jsm:1293:15) JS Stack trace: syncLoadDB@XPIDatabase.jsm:1293:15
[task 2019-02-12T09:37:45.505Z] 09:37:45 INFO - checkForChanges@XPIProvider.jsm:2638:9
[task 2019-02-12T09:37:45.506Z] 09:37:45 INFO - startup@XPIProvider.jsm:2224:7
[task 2019-02-12T09:37:45.507Z] 09:37:45 INFO - callProvider@AddonManager.jsm:204:12
[task 2019-02-12T09:37:45.508Z] 09:37:45 INFO - _startProvider@AddonManager.jsm:653:5
[task 2019-02-12T09:37:45.508Z] 09:37:45 INFO - startup@AddonManager.jsm:806:9
[task 2019-02-12T09:37:45.509Z] 09:37:45 INFO - startup@AddonManager.jsm:2788:5
[task 2019-02-12T09:37:45.510Z] 09:37:45 INFO - observe@addonManager.js:66:9
[task 2019-02-12T09:37:45.510Z] 09:37:45 INFO - promiseStartupManager@AddonTestUtils.jsm:743:5
[task 2019-02-12T09:37:45.511Z] 09:37:45 INFO - AsyncloadAddonManager@head.js:248:10
[task 2019-02-12T09:37:45.512Z] 09:37:45 INFO - test_setup@test_TelemetrySend.js:103:3
[task 2019-02-12T09:37:45.513Z] 09:37:45 INFO - async
run_next_test/_run_next_test/<@head.js:1435:22
[task 2019-02-12T09:37:45.513Z] 09:37:45 INFO - async*_run_next_test@head.js:1435:10
[task 2019-02-12T09:37:45.514Z] 09:37:45 INFO - run@head.js:686:9
[task 2019-02-12T09:37:45.515Z] 09:37:45 INFO - _do_main@head.js:224:3
[task 2019-02-12T09:37:45.515Z] 09:37:45 INFO - _execute_test@head.js:527:5
[task 2019-02-12T09:37:45.516Z] 09:37:45 INFO - @-e:1:1"
[task 2019-02-12T09:37:45.517Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965681 addons.xpi-utils DEBUG Starting async load of XPI database /tmp/xpc-profile-4Ia8jx/extensions.json"
[task 2019-02-12T09:37:45.517Z] 09:37:45 INFO - PID 16321 | 1549963965728 addons.xpi-utils DEBUG New add-on tel-system-xpi@tests.mozilla.org installed in app-system-defaults
[task 2019-02-12T09:37:45.518Z] 09:37:45 INFO - PID 16321 | 1549963965730 addons.xpi-utils WARN addMetadata: Add-on tel-system-xpi@tests.mozilla.org is invalid: [Exception... "Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsIFile.isFile]" nsresult: "0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)" location: "JS frame :: resource://gre/modules/addons/XPIInstall.jsm :: get :: line 194" data: no] Stack trace: get()@resource://gre/modules/addons/XPIInstall.jsm:194
[task 2019-02-12T09:37:45.518Z] 09:37:45 INFO - PID 16321 | loadManifestFromFile()@resource://gre/modules/addons/XPIInstall.jsm:597
[task 2019-02-12T09:37:45.519Z] 09:37:45 INFO - PID 16321 | 1549963965731 addons.xpi-utils WARN Could not uninstall invalid item from locked install location
[task 2019-02-12T09:37:45.520Z] 09:37:45 INFO - PID 16321 | 1549963965734 addons.xpi-utils DEBUG Updating add-on states
[task 2019-02-12T09:37:45.520Z] 09:37:45 INFO - PID 16321 | 1549963965737 addons.manager DEBUG Registering shutdown blocker for XPIProvider
[task 2019-02-12T09:37:45.521Z] 09:37:45 INFO - PID 16321 | 1549963965737 addons.manager DEBUG Provider finished startup: XPIProvider
[task 2019-02-12T09:37:45.521Z] 09:37:45 INFO - PID 16321 | 1549963965737 addons.manager DEBUG Starting provider: LightweightThemeManager
[task 2019-02-12T09:37:45.522Z] 09:37:45 INFO - PID 16321 | 1549963965737 addons.manager DEBUG Registering shutdown blocker for LightweightThemeManager
[task 2019-02-12T09:37:45.522Z] 09:37:45 INFO - PID 16321 | 1549963965737 addons.manager DEBUG Provider finished startup: LightweightThemeManager
[task 2019-02-12T09:37:45.523Z] 09:37:45 INFO - PID 16321 | 1549963965738 addons.manager DEBUG Starting provider: GMPProvider
[task 2019-02-12T09:37:45.524Z] 09:37:45 INFO - PID 16321 | 1549963965740 addons.manager DEBUG Registering shutdown blocker for GMPProvider
[task 2019-02-12T09:37:45.524Z] 09:37:45 INFO - PID 16321 | 1549963965740 addons.manager DEBUG Provider finished startup: GMPProvider
[task 2019-02-12T09:37:45.525Z] 09:37:45 INFO - PID 16321 | 1549963965740 addons.manager DEBUG Starting provider: PluginProvider
[task 2019-02-12T09:37:45.525Z] 09:37:45 INFO - PID 16321 | 1549963965740 addons.manager DEBUG Registering shutdown blocker for PluginProvider
[task 2019-02-12T09:37:45.526Z] 09:37:45 INFO - PID 16321 | 1549963965741 addons.manager DEBUG Provider finished startup: PluginProvider
[task 2019-02-12T09:37:45.527Z] 09:37:45 INFO - PID 16321 | JavaScript strict warning: resource://gre/modules/LightweightThemeManager.jsm, line 788: ReferenceError: reference to undefined property "version"
[task 2019-02-12T09:37:45.527Z] 09:37:45 INFO - PID 16321 | 1549963965745 addons.manager DEBUG Completed startup sequence
[task 2019-02-12T09:37:45.528Z] 09:37:45 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2019-02-12T09:37:45.528Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965728 addons.xpi-utils DEBUG New add-on tel-system-xpi@tests.mozilla.org installed in app-system-defaults"
[task 2019-02-12T09:37:45.529Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965730 addons.xpi-utils WARN addMetadata: Add-on tel-system-xpi@tests.mozilla.org is invalid: [Exception... "Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsIFile.isFile]" nsresult: "0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)" location: "JS frame :: resource://gre/modules/addons/XPIInstall.jsm :: get :: line 194" data: no] Stack trace: get()@resource://gre/modules/addons/XPIInstall.jsm:194
[task 2019-02-12T09:37:45.530Z] 09:37:45 INFO - loadManifestFromFile()@resource://gre/modules/addons/XPIInstall.jsm:597"
[task 2019-02-12T09:37:45.531Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965731 addons.xpi-utils WARN Could not uninstall invalid item from locked install location"
[task 2019-02-12T09:37:45.531Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965734 addons.xpi-utils DEBUG Updating add-on states"
[task 2019-02-12T09:37:45.532Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965737 addons.manager DEBUG Registering shutdown blocker for XPIProvider"
[task 2019-02-12T09:37:45.532Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965737 addons.manager DEBUG Provider finished startup: XPIProvider"
[task 2019-02-12T09:37:45.533Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965737 addons.manager DEBUG Starting provider: LightweightThemeManager"
[task 2019-02-12T09:37:45.533Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965737 addons.manager DEBUG Registering shutdown blocker for LightweightThemeManager"
[task 2019-02-12T09:37:45.534Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965737 addons.manager DEBUG Provider finished startup: LightweightThemeManager"
[task 2019-02-12T09:37:45.534Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965738 addons.manager DEBUG Starting provider: GMPProvider"
[task 2019-02-12T09:37:45.535Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965740 addons.manager DEBUG Registering shutdown blocker for GMPProvider"
[task 2019-02-12T09:37:45.535Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965740 addons.manager DEBUG Provider finished startup: GMPProvider"
[task 2019-02-12T09:37:45.536Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965740 addons.manager DEBUG Starting provider: PluginProvider"
[task 2019-02-12T09:37:45.536Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965740 addons.manager DEBUG Registering shutdown blocker for PluginProvider"
[task 2019-02-12T09:37:45.537Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965741 addons.manager DEBUG Provider finished startup: PluginProvider"
[task 2019-02-12T09:37:45.537Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "version"" {file: "resource://gre/modules/LightweightThemeManager.jsm" line: 788}]"
[task 2019-02-12T09:37:45.537Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965745 addons.manager DEBUG Completed startup sequence"
[task 2019-02-12T09:37:45.538Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965750 Toolkit.Telemetry TRACE TelemetryEnvironment::constructor"
[task 2019-02-12T09:37:45.538Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965786 Toolkit.Telemetry TRACE TelemetryEnvironment::_getGFXData - Only one display adapter detected."
[task 2019-02-12T09:37:45.539Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965788 Toolkit.Telemetry TRACE TelemetryEnvironment::_updateSearchEngine - ignoring early call"
[task 2019-02-12T09:37:45.539Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965789 Toolkit.Telemetry TRACE TelemetryEnvironment::_updateAddons"
[task 2019-02-12T09:37:45.540Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965799 Toolkit.Telemetry TRACE TelemetryEnvironment::_updateAddons: addons differ"
[task 2019-02-12T09:37:45.540Z] 09:37:45 INFO - PID 16321 | 1549963965819 addons.xpi-utils DEBUG XPI Database saved, setting schema version preference to 29
[task 2019-02-12T09:37:45.540Z] 09:37:45 INFO - "CONSOLE_MESSAGE: (info) 1549963965819 addons.xpi-utils DEBUG XPI Database saved, setting schema version preference to 29"
[task 2019-02-12T09:37:45.541Z] 09:37:45 INFO - <<<<<<<
[task 2019-02-12T09:37:45.541Z] 09:37:45 INFO - xpcshell return code: None
[task 2019-02-12T09:37:45.542Z] 09:37:45 INFO - toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | Process still running after test!
[task 2019-02-12T09:37:45.542Z] 09:37:45 INFO - INFO | Result summary:
[task 2019-02-12T09:37:45.543Z] 09:37:45 INFO - INFO | Passed: 393
[task 2019-02-12T09:37:45.543Z] 09:37:45 WARNING - INFO | Failed: 1
[task 2019-02-12T09:37:45.543Z] 09:37:45 WARNING - One or more unittests failed.
[task 2019-02-12T09:37:45.544Z] 09:37:45 INFO - INFO | Todo: 0
[task 2019-02-12T09:37:45.544Z] 09:37:45 INFO - INFO | Retried: 2
[task 2019-02-12T09:37:45.545Z] 09:37:45 INFO - SUITE-END | took 627s
[task 2019-02-12T09:37:45.545Z] 09:37:45 INFO - Node moz-http2 server shutting down ...
[task 2019-02-12T09:37:45.633Z] 09:37:45 ERROR - Return code: 1

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d8114eb631de710710af007f35d31ce72ef46d31

Backout:
https://hg.mozilla.org/integration/autoland/rev/17a6326ff8819ad6c27cf94cf91988712b7051b0

Flags: needinfo?(danielleleb12)
Flags: needinfo?(danielleleb12) → needinfo?(jrediger)
Attachment #9041034 - Attachment description: Bug 1135759 - Adds test coverage for submission path. → Bug 1135759 - Adds test coverage for submission path
Flags: needinfo?(jrediger)

Comment 11

a month ago
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0fbd0f5aab7
Adds test coverage for submission path r=janerik

Landing again with a slightly adjusted patch. It missed a recently introduced call (and I missed it in review/local test because my checkout wasn't updated either)

Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.