Closed Bug 1135788 Opened 9 years ago Closed 2 months ago

Commit hook for missing idl uuid revs blocks whitespace-only changes

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Fallen, Assigned: xidorn)

References

Details

Attachments

(1 file, 1 obsolete file)

Collapse whitespaces in idl file before comparison
3.09 KB, patch
gps
: review+
Details | Diff | Splinter Review 
The commit hook from bug 1128518 also rejects pushes where all that changed in an IDL interface is whitespaces. I know I could add IGNORE IDL for this, but it would be nice if it could be ignored in the hook.
Assignee: nobody → quanxunzhen
Status: NEW → ASSIGNED
Attachment #8710318 - Flags: review?(gps)
This patch should make it stop prompting for most harmless whitespace changes. Some code style fix could still get stuck, though.
Attachment #8710318 - Attachment is obsolete: true
Attachment #8710318 - Flags: review?(gps)
Attachment #8710324 - Flags: review?(gps) → review+
Please mark resolved once it gets deployed.
QA Contact: hwine → klibby

I'm sure someone has deployed this in the last 8 years :)

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.