1135788 - Commit hook for missing idl uuid revs blocks whitespace-only changes

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The commit hook from bug 1128518 also rejects pushes where all that changed in an IDL interface is whitespaces. I know I could add IGNORE IDL for this, but it would be nice if it could be ignored in the hook.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Collapse whitespaces in idl file before comparison

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

This patch should make it stop prompting for most harmless whitespace changes. Some code style fix could still get stuck, though.

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Collapse whitespaces in idl file before comparison

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/22c12053bfd3c1dbce25223d738e48c59c49f681
Bug 1135788 - Collapse whitespaces in idl file before comparison. r=gps

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Please mark resolved once it gets deployed.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I'm sure someone has deployed this in the last 8 years :)