Closed Bug 1135792 Opened 7 years ago Closed 7 years ago

Stop assuming that globals with non-worker descriptors are Window

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Right now codegen does this in CGDOMJSClass.define:

        if self.descriptor.isGlobal():
            if not self.descriptor.workers:
...
                      nsGlobalWindow::OuterObject, /* outerObject */

This is pretty busted for cases like bug 888600 and bug 1135220.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8568102 - Attachment is obsolete: true
Attachment #8568102 - Flags: review?(bugs)
Attachment #8568108 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/a95c3b5e0676
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.