1135801 - [[Prototype]] of self.NodeFilter should be Object.prototype, not Function.prototype

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Per <https://heycam.github.io/webidl/#interface-object>, after the first Note. Tested by dom/interfaces.html ("NodeFilter interface: existence and properties of interface object").

Comment 1

[Boris Zbarsky [:bzbarsky]]

Um... this test doesn't test anything other than the value NodeFilter.__proto__?

In particular, it seems to not test that typeof should be "object", that Object.prototype.toString.call(NodeFilter) should be "[object Object]", that NodeFilter.toString() should be "[object Object]", that NodeFilter should have no "length" property, etc.

That said, what do browsers actually do here?  Because it's not clear to me why this shouldn't just be a Function object, really...

Comment 2

[Cameron McCormack (:heycam)]

Inheriting from Function.prototype for consistency with non-callback interface objects may make sense, but is NodeFilter as ES6-class-y as other interface objects?  It's more just a storage place for some named constants.

In terms of what browsers do currently:

http://people.mozilla.org/~cmccormack/tests/callback-interface-proto.html

Gecko: Function.prototype
Blink: Function.prototype
WebKit: Object.prototype
IE11: Object.prototype

Comment 3

[Boris Zbarsky [:bzbarsky]]

Note that in WebKit all DOM interface objects have Object.prototypw as their prototype....

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: In case we ever decide to make this change

Comment 5

[Peter Van der Beken [:peterv]]

The spec was changed in https://github.com/heycam/webidl/issues/96.