put global xbl widgets on a diet

RESOLVED FIXED in mozilla0.9.9

Status

()

Core
XUL
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: Joe Hewitt (gone), Assigned: Blake Ross)

Tracking

Trunk
mozilla0.9.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.67 KB, patch
Details | Diff | Splinter Review
(Reporter)

Description

17 years ago
I need to scan through our global xbl bindings looking for stuff that can be
lazily executed or removed altogether.  I suspect we are doing a lot of work on
startup that can be postponed until they are needed.  Ideally, binding
constructors and fields should be doing very little work.
(Assignee)

Comment 1

17 years ago
Created attachment 60901 [details] [diff] [review]
patch

patch - here's a start

I don't think there's much improvement to be made in this area, in general.
(Assignee)

Comment 2

17 years ago
Please note that any mac-only optimizations were completely unintentional.  I 
added the !mac shortcircuit after making them.  If the reviewer would like, I 
can remove them.
(Reporter)

Comment 3

17 years ago
Comment on attachment 60901 [details] [diff] [review]
patch

sr=hewitt
Attachment #60901 - Flags: superreview+
(Assignee)

Comment 4

17 years ago
Created attachment 61219 [details] [diff] [review]
minor patch

since most dialogs don't specify buttons, it was pointless to do it as we had
been.
(Assignee)

Updated

17 years ago
Attachment #60901 - Attachment is obsolete: true
Attachment #60901 - Flags: review+
(Reporter)

Updated

17 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
(Reporter)

Comment 5

17 years ago
last month's xul perf work included most of the xbl dieting that I intended to
do.  blake, since you have a couple patches here I'll give this to you and you
can close it as you please.
Assignee: hewitt → blaker
Status: ASSIGNED → NEW
(Assignee)

Comment 6

17 years ago
nah. will fix other stuff as it comes up.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.