Remove nsPrintProgress and probably nsPrintProgressParams from OS X printing implementation

RESOLVED FIXED in Firefox 58

Status

()

Toolkit
Printing
RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: mconley, Assigned: m_kato)

Tracking

unspecified
mozilla58
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

The OS X implementation of nsPrintingPromptService returns NS_ERROR_NOT_IMPLEMENTED for ShowProgress. The upshot being that OS X never shows the print progress dialog, ever.

And yet, there's a bit of code there, probably leftovers from yesteryore, to show a print progress dialog on OS X. I'm thinking particularly of nsPrintProgress and nsPrintProgressParams.

We should remove that dead code.
See Also: → bug 1134891
Comment hidden (mozreview-request)
Assignee: nobody → m_kato
Comment on attachment 8912601 [details]
Bug 1135901 - Remove nsPrintProgress and nsPrintProgressParams from OS X printing implementation.

https://reviewboard.mozilla.org/r/183926/#review189492

Thank you.

It looks good to me.

I'm not sure the reason that why nsPrintingPromptService implement nsIWebProgressListener, but I think that we can drop this implementation. But this is not related to this bug. So I'll remove it after landed this patch.

Thanks.
Attachment #8912601 - Flags: review?(mantaroh) → review+

Comment 3

3 months ago
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/244604e87eec
Remove nsPrintProgress and nsPrintProgressParams from OS X printing implementation. r=mantaroh
https://hg.mozilla.org/mozilla-central/rev/244604e87eec
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.