1135904 - [Cost Control] "Reset mobile & Wi-Fi data" is cut off on the action menu

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: TruncateAndRunOff.png

Description:
The string "Reset mobile & Wi-Fi data" on the "Reset Data usage" screen does not seem to fit inside the button. The string is truncated, and also runs off the screen on the right side.

Repro Steps:
1) Update a Flame to 20150223010224.
2) Set the device language in Arabic under Settings > Language.
3) Open Usage app, and go through FTE if necessary.
4) On the main page, press the settings icon.
5) Select "Reset".
6) Observe the text on the last button.

Actual:
The string "Reset mobile & Wi-Fi data" is truncated and cut off at the right side.

Expected:
The sring "Reset mobile & Wi-Fi data" is NOT truncated and fits inside the button.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150223010224
Gaia: a6881205deae450757a8d1e1ed65e5e5be0ec633
Gecko: 86d2bb8bb1c9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 5/5
See attached: screenshot

Comment 1

[Yeojin Chung [:YeojinC]]

This issue also reproduces on Flame 2.2.

Result: The string "Reset mobile & Wi-Fi data" is truncated and cut off at the right side.

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150223002503
Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1
Gecko: 9fd3441c8983
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Fabien Cazenave [:kaze]]

Francesco, can you look at this one please?

Comment 3

[Francesco Lodolo [:flod]]

[role="dialog"][data-type="action"] > menu > button has a lateral padding of 1.2rem, but it's not applied on the button when the string is long, even if I switch the dialog to LTR or change the string in Italian.

Definitely an issue, but not just RTL. Unfortunately I can't be much of help, no clue why that happens.

Comment 4

[Dylan Oliver [:doliver]]

Removing RTL dependency.

Comment 5

[Shing Lyu [:shinglyu]]

NI Marshall to see if he knows anyone who can help

Comment 6

[Marshall Culpepper [:marshall_law]]

adding Salva

Comment 7

[Shing Lyu [:shinglyu]]

(Delphine is in South Aferica, NI Parul)

Parul, can you help by providing some input from the RTL perspective? I guess people are not sure what to do with this bug.

Comment 8

[Delphine Lebédel]

Hi Shing. Since this email isn't linked to any RTL dependency anymore, this didn't get caught by any of my filters, so only getting to this now :)
If I understand correctly comment 3, this is not only and RTL issue, and I *believe* this is something UX should have a look at. Parul and I are more on QA-side, so wouldn't be able to advise on how to fix this. 
Ni on Firefox OS UX for this one. thanks!

Comment 9

[Stephany Wilkes]

Flagging Amy to see if she can help on layout here, since we worked Eric to death this week.

Comment 10

[Amy Lee [:amylee] UX]

(In reply to Stephany Wilkes from comment #9)
> Flagging Amy to see if she can help on layout here, since we worked Eric to
> death this week.

Can someone confirm how much of the string is being cut off? This would help me determine how much extra space we need to accommodate the string. Thanks

Comment 11

[Stephany Wilkes]

Amy, I think that's shown in the screenshot.

Comment 12

[Amy Lee [:amylee] UX]

Attachment: Screen.png

Hi Steph, 

What I meant was figuring out how much text was actually being cut of (i.e if it was cutting off 1 word or 10 words).

I asked a contributor that knew Arabic and he was able to provide me with the full phrase. So based on what he had sent me this is what I mocked up. Is there a someone from l10n team that we can ask to shorten the word? If not, then this would be my recommendation (see attached).

Comment 13

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to Amy Lee [:amylee] from comment #12)
> Created attachment 8588732 [details]
> Screen.png
> 
> Hi Steph, 
> 
> What I meant was figuring out how much text was actually being cut of (i.e
> if it was cutting off 1 word or 10 words).
> 
> I asked a contributor that knew Arabic and he was able to provide me with
> the full phrase. So based on what he had sent me this is what I mocked up.
> Is there a someone from l10n team that we can ask to shorten the word? If
> not, then this would be my recommendation (see attached).

I'll gladly look into this.

Comment 14

[Shing Lyu [:shinglyu]]

Any update, Ahmed? :)

Comment 15

[Delphine Lebédel]

FWIW: I think Ahmed is busy with Phoxygen a lot these days. Adding Rami, Arabic localizer in need info just in case he can take over.
Rami: please kindly see comment 12 asking for a string to be shortened

Comment 16

[Delphine Lebédel]

Adding this as an RTL dependency.
Triage: P2

Comment 17

[Delphine Lebédel]

oh wait, sorry - as per comment 3, this is not only an RTL issue. This will be an issue in many other locales. We can't get a fix per l10n change of string in this case. Removing the ni's, sorry for the noise

Comment 18

[Delphine Lebédel]

Amy: if you look at the Transvision tool here it will let you know exactly how much is being cut off: http://transvision.mozfr.org/?recherche=Reset+mobile+%26+Wi-Fi+data&repo=gaia&sourcelocale=en-US&locale=ar&search_type=strings

Comment 19

[Amy Lee [:amylee] UX]

(In reply to Delphine Lebédel [:delphine - PTO Monday April 27]] from comment #18)
> Amy: if you look at the Transvision tool here it will let you know exactly
> how much is being cut off:
> http://transvision.mozfr.org/?recherche=Reset+mobile+%26+Wi-
> Fi+data&repo=gaia&sourcelocale=en-US&locale=ar&search_type=strings

Hi Delphine, 

I had provided my recommendation in comment 12 in the case that we can't shorten the string length. I had attached a screenshot of the full string with reduced font size of 15.5px. Let me know if this works.

Comment 20

[Stephany Wilkes]

Removing the flag to me since this is being handled.

Comment 21

[Delphine Lebédel]

Hi Amy. As per comment 17, shortening the string is not possible and this affects other locales than Arabic. Provided that the fix covers all the other locales that are as long as the Arabic string (see https://transvision.mozfr.org/string/?entity=apps/costcontrol/costcontrol.properties:reset-all&repo=gaia to get an idea), then your fix should work, I think!

Comment 22

[Amy Lee [:amylee] UX]

Attachment: Cost_Control_String.png

Hi, 

I took the longest string in your link and tested it. Can we have a different size font for latin-based languages and Arabic? If not I'm afraid the size will have to be reduced further (See attached).

Comment 23

[Delphine Lebédel]

I'm not the right person to be asking this. Probably someone from UX? I don't know

Comment 24

[Amy Lee [:amylee] UX]

I meant from a technical standpoint if we are able to adjust the font size for a specific scenario without having to reduce the font size globally. Please adjust the font size to 15.5px for Arabic. In cases where the string is too long, it will have to be broken into two lines.

Thanks

Comment 25

[Shing Lyu [:shinglyu]]

Hi Josh, can you help with this? Thanks.

Comment 26

[Josh Cheng [:josh]]

Hi Jaime,
Do we accept different font size tuning for same component on different locale per comment 22 from Amy? Thanks!

Comment 27

[BMO Automation]

Firefox OS is not being worked on