1135908 - [E10s] Proxy for Character/SelectionCount()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8568227 [details] [diff] [review]
v1

>+  if (accWrap) {
>+    HyperTextAccessible* textAcc = accWrap->AsHyperText();
>+    return
>+      textAcc->IsDefunct() ? 0 : static_cast<gint>(textAcc->CharacterCount());
>+  }
>+  if (ProxyAccessible* proxy = GetProxy(ATK_OBJECT(aText))) {

blank line after } please

>+    return proxy->CharacterCount();
>+  }
>+  return 0;

same

>+  if (accWrap) {
>+    HyperTextAccessible* text = accWrap->AsHyperText();
>+    if (!text || !text->IsTextRole()) {
>+      return 0;
>+    }
> 
>-  HyperTextAccessible* text = accWrap->AsHyperText();
>-  if (!text || !text->IsTextRole())
>-    return 0;
>-
>-  return text->SelectionCount();
>+    return text->SelectionCount();
>+  }
>+  if (ProxyAccessible* proxy = GetProxy(ATK_OBJECT(aText))) {

and here

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Is that some a11y coding style rule?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: +new lines

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b60708e9bedb

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b60708e9bedb

Comment 6

[Trevor Saunders (:tbsaunde)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Is that some a11y coding style rule?

Well, I thought it was more general than just a11y.  Anyway I find it much easier to deal with if you don't mind.