Closed
Bug 1135913
Opened 9 years ago
Closed 9 years ago
Unify SVGTextFrame's NotifyBeforeDecorationLine and NotifyDecorationLinePathEmitted callbacks
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(4 files)
8.26 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
1.79 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
5.95 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
5.09 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
More simplification of the horrible callbacks. As with previous efforts this moves us incrementally in the right direction rather than getting us to a nice clean end state.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8568309 -
Flags: review?(cam)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8568310 -
Flags: review?(cam)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8568311 -
Flags: review?(cam)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8568318 -
Flags: review?(cam)
Updated•9 years ago
|
Attachment #8568309 -
Flags: review?(cam) → review+
Updated•9 years ago
|
Attachment #8568310 -
Flags: review?(cam) → review+
Updated•9 years ago
|
Attachment #8568311 -
Flags: review?(cam) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8568318 [details] [diff] [review] part 4 - unify SVGTextFrame's NotifyBeforeSelectionDecorationLine and NotifySelectionDecorationLinePathEmitted callbacks Review of attachment 8568318 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsTextFrame.h @@ +343,5 @@ > */ > virtual void PaintDecorationLine(Rect aPath, nscolor aColor) { } > > /** > + * Called before/after selected text is drawn to have a decoration line According to my comment on nsTextFrame::DrawPathCallbacks, this is only called after the text itself is painted. Can you verify that, and if so, remove the "before/" in this comment? Also please update the nsTextFrame::DrawPathCallbacks comment for this new callback.
Attachment #8568318 -
Flags: review?(cam) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/07521b781101 https://hg.mozilla.org/integration/mozilla-inbound/rev/4782e0a1b370 https://hg.mozilla.org/integration/mozilla-inbound/rev/521d4346f3a2 https://hg.mozilla.org/integration/mozilla-inbound/rev/1840824592e4
https://hg.mozilla.org/mozilla-central/rev/07521b781101 https://hg.mozilla.org/mozilla-central/rev/4782e0a1b370 https://hg.mozilla.org/mozilla-central/rev/521d4346f3a2 https://hg.mozilla.org/mozilla-central/rev/1840824592e4
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•