Closed Bug 1135913 Opened 9 years ago Closed 9 years ago

Unify SVGTextFrame's NotifyBeforeDecorationLine and NotifyDecorationLinePathEmitted callbacks

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(4 files)

More simplification of the horrible callbacks. As with previous efforts this moves us incrementally in the right direction rather than getting us to a nice clean end state.
Attachment #8568309 - Flags: review?(cam) → review+
Attachment #8568310 - Flags: review?(cam) → review+
Attachment #8568311 - Flags: review?(cam) → review+
Comment on attachment 8568318 [details] [diff] [review]
part 4 - unify SVGTextFrame's NotifyBeforeSelectionDecorationLine and NotifySelectionDecorationLinePathEmitted callbacks

Review of attachment 8568318 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsTextFrame.h
@@ +343,5 @@
>       */
>      virtual void PaintDecorationLine(Rect aPath, nscolor aColor) { }
>  
>      /**
> +     * Called before/after selected text is drawn to have a decoration line

According to my comment on nsTextFrame::DrawPathCallbacks, this is only called after the text itself is painted.  Can you verify that, and if so, remove the "before/" in this comment?

Also please update the nsTextFrame::DrawPathCallbacks comment for this new callback.
Attachment #8568318 - Flags: review?(cam) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.