1135913 - Unify SVGTextFrame's NotifyBeforeDecorationLine and NotifyDecorationLinePathEmitted callbacks

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Watt [:jwatt]]

More simplification of the horrible callbacks. As with previous efforts this moves us incrementally in the right direction rather than getting us to a nice clean end state.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: part 1 - simplify nsCSSRendering::DecorationLineToPath to not require a context

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: part 2 - separate the |aDecorationType == eNormalDecoration| blocks to make the upcoming patches clearer

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: part 3 - unify SVGTextFrame's NotifyBeforeDecorationLine and NotifyDecorationLinePathEmitted callbacks

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: part 4 - unify SVGTextFrame's NotifyBeforeSelectionDecorationLine and NotifySelectionDecorationLinePathEmitted callbacks

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8568318 [details] [diff] [review]
part 4 - unify SVGTextFrame's NotifyBeforeSelectionDecorationLine and NotifySelectionDecorationLinePathEmitted callbacks

Review of attachment 8568318 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsTextFrame.h
@@ +343,5 @@
>       */
>      virtual void PaintDecorationLine(Rect aPath, nscolor aColor) { }
>  
>      /**
> +     * Called before/after selected text is drawn to have a decoration line

According to my comment on nsTextFrame::DrawPathCallbacks, this is only called after the text itself is painted.  Can you verify that, and if so, remove the "before/" in this comment?

Also please update the nsTextFrame::DrawPathCallbacks comment for this new callback.

Comment 6

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07521b781101
https://hg.mozilla.org/integration/mozilla-inbound/rev/4782e0a1b370
https://hg.mozilla.org/integration/mozilla-inbound/rev/521d4346f3a2
https://hg.mozilla.org/integration/mozilla-inbound/rev/1840824592e4

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/07521b781101
https://hg.mozilla.org/mozilla-central/rev/4782e0a1b370
https://hg.mozilla.org/mozilla-central/rev/521d4346f3a2
https://hg.mozilla.org/mozilla-central/rev/1840824592e4