1136042 - Wrong new tab label shown for a couple of locales when opening a new tab

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

[Tracking Requested - why for this release]:

This is a regression we have found with our Mozmill tests while running tests against the new Firefox 37.0b1 builds. 

When opening a new tab we see failures like:

> Correct tab title - 'Isilungelelanisi Semigca Esitsha' should equal 'Ithebhu entsha'

This is e.g. for the xh locale.

Steps:
1. Download and install the xh build for Firefox 37.0b1: http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/37.0b1-candidates/build1/
2. Start Firefox 
3. Open a new tab -> 'Isilungelelanisi Semigca Esitsha' is shown
4. Turn off about:newtab preloading via the pref 'browser.newtab.preload'
5. Open a new tab -> 'Ithebhu entsha' is shown
6. Wait some seconds and open another tab -> 'Isilungelelanisi Semigca Esitsha' is shown

There is clearly a discrepancy here in what kind of label we show, and I assume it somewhat regressed by a change for about:newtab during the 37 dev cycle.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For the list of locales please see http://mozmill-release.blargon7.com/#/functional/failure?app=Firefox&branch=37&platform=Linux&from=2015-02-23&to=2015-02-24&test=%2FtestTabbedBrowsing%2FtestNewTab.js&func=testNewTab

Comment 2

[Francesco Lodolo [:flod]]

The string in #3 is tabs.emptyTabTitle from browser/chrome/browser/tabbrowser.properties
The string in #5 is newtab.pageTitle from browser/chrome/browser/newTab.dtd

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Tested latest aurora build for xh and it is also affected.

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

Tracking localization regression.

ni Gavin to help prioritize and find an owner.

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

I spoke with Gavin. This doesn't look critical for the release and we're not going to be able to fix it in time. I'm leaving this tracked for 38+ as I want to see this fixed in a subsequent release.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Affected locales: kn, id, hy-AM, mr, xh.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Francesco, do you know who could help us on this? Thanks

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #7)
> Francesco, do you know who could help us on this? Thanks

The failing test uncovered a lack of consistency for the "New Tab" translation in some locales. We can file individual bugs in each locale and ask localizers to check this.

But the underlying issue would still be there (we're using two different strings for the same thing, and we didn't use to).

Comment 9

[Sylvestre Ledru [:Sylvestre]]

flod, OK. Can you take care of opening a bug for each locales so that it is fixed for 38 and the try to fix the issue itself for 39? Good plan?

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Liz Henry (:lizzard) from comment #6)
> Affected locales: kn, id, hy-AM, mr, xh.

So, I filed bugs for id, mr, xh.

kn should already be fixed by the last landings on aurora (fx39).

I don't get the hy-AM failure, as far as I can tell the 2 strings are exactly the same (try copy the first and search in the page).

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Two of the three have been already fixed.
I won't track them anymore as we won't block the release anyway (and I am clearing Gavin's ni)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Is this still an issue?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is more a question to Flod given that I do not know the bugs he filed.

Comment 14

[Francesco Lodolo [:flod]]

Bug 1152725 is still open and has seen no action so far.

I guess this bug is actually a WONTFIX, since we're just fixing the consequences.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Given that some of the locales have been fixed I would go with a WFM. Those locales which are still broken we could exclude from our testing.