Closed
Bug 1136057
Opened 9 years ago
Closed 9 years ago
TEST-UNEXPECTED-FAIL | keyboard/test/unit/keyboard/layout_rendering_manager_test.js | LayoutRenderingManager Rendered resize event - expected false to be true
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-master | --- | fixed |
People
(Reporter: rudyl, Assigned: rudyl)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
23:49:59 INFO - TEST-UNEXPECTED-FAIL | keyboard/test/unit/keyboard/layout_rendering_manager_test.js | LayoutRenderingManager Rendered resize event - expected false to be true 23:49:59 INFO - Error: expected false to be true 23:49:59 INFO - at chaiAssert (app://keyboard.gaiamobile.org/common/test/helper.js:32:1) 23:49:59 INFO - at (anonymous) (app://keyboard.gaiamobile.org/common/vendor/chai/chai.js:1215:1) 23:49:59 INFO - at get (app://keyboard.gaiamobile.org/common/vendor/chai/chai.js:3669:22) 23:49:59 INFO - at doAsserterAsyncAndAddThen (app://keyboard.gaiamobile.org/common/vendor/chai/chai-as-promised.js:294:1) 23:49:59 INFO - at (anonymous) (app://keyboard.gaiamobile.org/common/vendor/chai/chai-as-promised.js:284:25) 23:49:59 INFO - at get (app://keyboard.gaiamobile.org/common/vendor/chai/chai.js:4574:22) 23:49:59 INFO - at isTrue (app://keyboard.gaiamobile.org/common/vendor/chai/chai.js:2560:5) 23:49:59 INFO - at (anonymous) (app://keyboard.gaiamobile.org/test/unit/keyboard/layout_rendering_manager_test.js:236:7) 23:49:59 INFO - at wrapper (app://keyboard.gaiamobile.org/common/test/mocha_generators.js:62:19) 23:49:59 INFO - at run (app://keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:3709:7) 23:49:59 INFO - at runTest (app://keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4081:5) 23:49:59 INFO - at (anonymous) (app://keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4127:7) 23:49:59 INFO - at next (app://keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4007:1) 23:49:59 INFO - at (anonymous) (app://keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4016:7) 23:49:59 INFO - at next (app://keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:3964:1) 23:49:59 INFO - at (anonymous) (app://keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:3979:7) 23:49:59 INFO - at done (app://keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:3700:5) 23:49:59 INFO - at (anonymous) (app://keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:3712:9) 23:49:59 INFO - at (anonymous) (app://keyboard.gaiamobile.org/common/test/mocha_generators.js:46:20) Example failure, https://tbpl.mozilla.org/php/getParsedLog.php?id=59719786&tree=Gaia-Try
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
It turns out this failure would only occur with the patch in bug 1098168. Still not sure why document.hidden would become true for this case, so that it would do early return in resize event handler.
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8569066 [details] [review] [gaia] RudyLu:keyboard/mock_document-hidden > mozilla-b2g:master This patch corrected the mock in apps/keyboard/test/unit/keyboard/layout_rendering_manager_test.js for document.hidden, and should be ok to resolve the strange side effect of the patch in bug 1098168. Alive, could you please review this? Hope this could help to unblock the landing of your patch.
Attachment #8569066 -
Flags: review?(alive)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Comment 4•9 years ago
|
||
Comment on attachment 8569066 [details] [review] [gaia] RudyLu:keyboard/mock_document-hidden > mozilla-b2g:master Thanks, but I'd fixed the problem in a general way. You are still able to do this though.
Attachment #8569066 -
Flags: review?(alive) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Gaia master, https://github.com/mozilla-b2g/gaia/commit/efb34ea4da55cb7bc6f1dc5776788d3fc75d6b8b -- Thanks for the review, let me know if there is anything I can help with.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-b2g-master:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•