Closed
Bug 1136071
Opened 9 years ago
Closed 9 years ago
TelemetryPing/TelemetrySession need to return a promise when the initialisation is already in progress.
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(firefox39 fixed)
RESOLVED
FIXED
Firefox 39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: Dexter, Assigned: Dexter)
References
Details
(Whiteboard: [ready])
Attachments
(1 file, 1 obsolete file)
7.46 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
Both TelemetryPing.jsm and TelemetrySession.jsm return |_delayedInitTask| if the initialisation is already in progress. We should return a promise instead.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
This patch makes |setupChromeProcess| return a promise if the initialisation task has already in started.
Attachment #8568465 -
Flags: review?(gfritzsche)
Comment 2•9 years ago
|
||
Comment on attachment 8568465 [details] [diff] [review] bug1136071.patch Review of attachment 8568465 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/TelemetrySession.jsm @@ +1049,5 @@ > > this._log.trace("setupChromeProcess"); > > if (this._delayedInitTask) { > this._log.error("setupTelemetry - init task already running"); Can we fix this trace (and the one below) to say "setupChromeProcess" while we're here?
Attachment #8568465 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Fixes the log prints.
Attachment #8568465 -
Attachment is obsolete: true
Attachment #8568475 -
Flags: review+
Updated•9 years ago
|
Whiteboard: [ready]
Comment 4•9 years ago
|
||
Pushed in: https://hg.mozilla.org/integration/fx-team/pushloghtml?changeset=b83c3fa8c80f
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/61a2290ead89
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•