1136071 - TelemetryPing/TelemetrySession need to return a promise when the initialisation is already in progress.

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Alessio Placitelli [:Dexter]]

Both TelemetryPing.jsm and TelemetrySession.jsm return |_delayedInitTask| if the initialisation is already in progress. We should return a promise instead.

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: bug1136071.patch

This patch makes |setupChromeProcess| return a promise if the initialisation task has already in started.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8568465 [details] [diff] [review]
bug1136071.patch

Review of attachment 8568465 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +1049,5 @@
>  
>      this._log.trace("setupChromeProcess");
>  
>      if (this._delayedInitTask) {
>        this._log.error("setupTelemetry - init task already running");

Can we fix this trace (and the one below) to say "setupChromeProcess" while we're here?

Comment 3

[Alessio Placitelli [:Dexter]]

Attachment: bug1136071.patch - v2

Fixes the log prints.

Comment 4

[Georg Fritzsche [:gfritzsche]]

Pushed in: https://hg.mozilla.org/integration/fx-team/pushloghtml?changeset=b83c3fa8c80f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/61a2290ead89