test_TelemetrySendOldPings.js is missing AddonManager initialization

RESOLVED FIXED in Firefox 39

Status

Firefox Health Report
Client: Desktop
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gfritzsche, Assigned: gfritzsche)

Tracking

Trunk
Firefox 39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [ready])

Attachments

(1 attachment)

A try run shows that we are missing AM initialization for that test.
We really should fix that test to run on debug builds too so we don't miss that locally.

16:43:46     INFO -  toolkit/components/telemetry/tests/unit/test_TelemetrySendOldPings.js | Starting setupEnvironment
16:43:46     INFO -  (xpcshell/head.js) | test setupEnvironment pending (2)
16:43:46     INFO -  PROCESS | 4687 | 1424738626692	Toolkit.Telemetry	TRACE	TelemetryPing::setupTelemetry
16:43:46     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
16:43:46     INFO -  "CONSOLE_MESSAGE: (info) 1424738626692	Toolkit.Telemetry	TRACE	TelemetryPing::setupTelemetry"
16:43:46     INFO -  PROCESS | 4687 | 1424738626805	Toolkit.Telemetry	TRACE	TelemetryEnvironment::init
16:43:46     INFO -  PROCESS | 4687 | 1424738626805	Toolkit.Telemetry	TRACE	TelemetryEnvironment::_startWatchingPrefs - null
16:43:46     INFO -  PROCESS | 4687 | *************************
16:43:46     INFO -  PROCESS | 4687 | A coding exception was thrown and uncaught in a Task.
16:43:46     INFO -  PROCESS | 4687 | Full message: TypeError: gShutdownBarrier is null
16:43:46     INFO -  PROCESS | 4687 | Full stack: this.AddonManager.shutdown@resource://gre/modules/AddonManager.jsm:2973:5
16:43:46     INFO -  PROCESS | 4687 | this.TelemetryEnvironment.init@resource://gre/modules/TelemetryEnvironment.jsm:201:5
16:43:46     INFO -  PROCESS | 4687 | setupTelemetry/this._delayedInitTask<@resource://gre/modules/TelemetryPing.jsm:710:15
16:43:46     INFO -  PROCESS | 4687 | _run_next_test@/builds/slave/talos-slave/test/build/tests/xpcshell/head.js:1375:9
16:43:46     INFO -  PROCESS | 4687 | do_execute_soon/<.run@/builds/slave/talos-slave/test/build/tests/xpcshell/head.js:644:9
16:43:46     INFO -  PROCESS | 4687 | _do_main@/builds/slave/talos-slave/test/build/tests/xpcshell/head.js:207:5
16:43:46     INFO -  PROCESS | 4687 | _execute_test@/builds/slave/talos-slave/test/build/tests/xpcshell/head.js:504:5
16:43:46     INFO -  PROCESS | 4687 | @-e:1:1
16:43:46     INFO -  PROCESS | 4687 | *************************
Created attachment 8568481 [details] [diff] [review]
Fix missing AddonManager initialization

Trivial patch - Nathan, do you think you can review this?
Assignee: nobody → gfritzsche
Status: NEW → ASSIGNED
Attachment #8568481 - Flags: review?(nfroyd)
Comment on attachment 8568481 [details] [diff] [review]
Fix missing AddonManager initialization

Review of attachment 8568481 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the createAppInfo change below; if that's not correct, then I'd like to see another patch, because I don't understand where loadAddonManager is coming from.

::: toolkit/components/telemetry/tests/unit/test_TelemetrySendOldPings.js
@@ +186,5 @@
>  function run_test() {
>    gHttpServer.registerPrefixHandler("/submit/telemetry/", pingHandler);
>    gHttpServer.start(-1);
>    do_get_profile();
> +  loadAddonManager("xpcshell@tests.mozilla.org", "XPCShell", "1", "1.9.2");

I think you mean |createAppInfo|, don't you?
Attachment #8568481 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #2)
> r=me with the createAppInfo change below; if that's not correct, then I'd
> like to see another patch, because I don't understand where loadAddonManager
> is coming from.

Cleared up on IRC that this is in the context of the other patches from the bug 1069869 dependency tree.
Whiteboard: [ready]
https://hg.mozilla.org/mozilla-central/rev/c21f6c1b87c3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39

Comment 6

3 years ago
Sorry for the noise, I don't have a better way to try and repro bug 1137149
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 39 → ---

Updated

3 years ago
Status: REOPENED → ASSIGNED

Comment 7

3 years ago
https://hg.mozilla.org/mozilla-central/rev/c21f6c1b87c3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
You need to log in before you can comment on or make changes to this bug.