1136107 - crash in `anonymous namespace''::wasapi_stream_start(cubeb_stream*)

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Xavier Delgado]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150223103044

Steps to reproduce:

1) Launch FF39 Nightly on 8.1
2) Launch a youtube video
3) Click "Pause"
4) Unplug speaker audio output jack (Terratec Aureon 7.1 USB)
5) Plug headphones output jack



Actual results:

Firefox crashes


Expected results:

I should have continue to listen video with headphones
More reports: https://crash-stats.mozilla.com/signature/?signature=%60anonymous+namespace%27%27%3A%3Awasapi_stream_start(cubeb_stream*)&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&page=1

Comment 1

[Matthew Gregan [:kinetik]]

Simple fix, the assert in wasapi_stream_start is overly cautious.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Handle reconfiguring audio device if it went away while the stream was stopped

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8571151 [details] [diff] [review]
Handle reconfiguring audio device if it went away while the stream was stopped

Actually not just an assert.  Problem is that the default audio device has gone away while the stream has stopped, and we don't expect to need to reconfigure it when restarting the stream.

Comment 4

[Matthew Gregan [:kinetik]]

This patch should also take care of the wasapi_stream_stop crashes that show up in the crash stats for 39.0a1.

Comment 5

[Matthew Gregan [:kinetik]]

That applies to 38.0a2 as well.

Comment 6

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6d887fcc49c

Comment 7

[Matthew Gregan [:kinetik]]

Comment on attachment 8571151 [details] [diff] [review]
Handle reconfiguring audio device if it went away while the stream was stopped

Approval Request Comment
[Feature/regressing bug #]: bug 698079/bug 1134078
[User impact if declined]: Crash (fatal assertion) when pausing or resuming playback after the audio device has changed
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: low risk
[String/UUID change made/needed]: none

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6d887fcc49c

Comment 9

[Xavier Delgado]

No longer reproducible with latest Nightly from 2015-03-08 on Windows 8.1. Changed the status accordingly.

But if you plug and unplug audio jacks on YouTube without clicking "Pause", the sound doesn't work.
However, it was like that before.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5405ed0953e7