Closed Bug 1136107 Opened 5 years ago Closed 5 years ago

crash in `anonymous namespace''::wasapi_stream_start(cubeb_stream*)

Categories

(Core :: Audio/Video, defect, critical)

39 Branch
x86
Windows 8.1
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla39
Tracking Status
firefox38 --- fixed
firefox39 --- verified

People

(Reporter: xavier.delgado, Assigned: kinetik)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150223103044

Steps to reproduce:

1) Launch FF39 Nightly on 8.1
2) Launch a youtube video
3) Click "Pause"
4) Unplug speaker audio output jack (Terratec Aureon 7.1 USB)
5) Plug headphones output jack



Actual results:

Firefox crashes


Expected results:

I should have continue to listen video with headphones
More reports: https://crash-stats.mozilla.com/signature/?signature=%60anonymous+namespace%27%27%3A%3Awasapi_stream_start(cubeb_stream*)&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&page=1
Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Simple fix, the assert in wasapi_stream_start is overly cautious.
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Comment on attachment 8571151 [details] [diff] [review]
Handle reconfiguring audio device if it went away while the stream was stopped

Actually not just an assert.  Problem is that the default audio device has gone away while the stream has stopped, and we don't expect to need to reconfigure it when restarting the stream.
Attachment #8571151 - Flags: review?(padenot)
Attachment #8571151 - Flags: review?(padenot) → review+
This patch should also take care of the wasapi_stream_stop crashes that show up in the crash stats for 39.0a1.
That applies to 38.0a2 as well.
Comment on attachment 8571151 [details] [diff] [review]
Handle reconfiguring audio device if it went away while the stream was stopped

Approval Request Comment
[Feature/regressing bug #]: bug 698079/bug 1134078
[User impact if declined]: Crash (fatal assertion) when pausing or resuming playback after the audio device has changed
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: low risk
[String/UUID change made/needed]: none
Attachment #8571151 - Flags: approval-mozilla-aurora?
Blocks: 1134078
https://hg.mozilla.org/mozilla-central/rev/d6d887fcc49c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
QA Whiteboard: [good first verify]
Status: RESOLVED → VERIFIED
No longer reproducible with latest Nightly from 2015-03-08 on Windows 8.1. Changed the status accordingly.

But if you plug and unplug audio jacks on YouTube without clicking "Pause", the sound doesn't work.
However, it was like that before.
Attachment #8571151 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Duplicate of this bug: 1143540
You need to log in before you can comment on or make changes to this bug.