Closed
Bug 1136125
Opened 11 years ago
Closed 11 years ago
Reduce memory usage of Bugzilla::CGI->send_cookie()
Categories
(Bugzilla :: Bugzilla-General, defect)
Bugzilla
Bugzilla-General
Tracking
()
RESOLVED
FIXED
Bugzilla 6.0
People
(Reporter: dylan, Assigned: dylan)
Details
Attachments
(1 file, 1 obsolete file)
|
1.41 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
Bugzilla::CGI->send_cookie() uses shift() to over an array to turn it into a hashref, and later unshifts the values back into an array. Calling shift twice is usually bad (splice should be used). In this case, the code duplicates the normal behavior of hashes and arrays.
|
Assignee | |
Comment 1•11 years ago
|
||
Fixing a minor annoyance.
Attachment #8568516 -
Flags: review?(dkl)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8568516 [details] [diff] [review]
bug-1136125-v1.patch
There's an over-zealous text change in this. Canceling review for now.
Attachment #8568516 -
Flags: review?(dkl)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8568516 -
Attachment is obsolete: true
Attachment #8568518 -
Flags: review?(dkl)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8568518 [details] [diff] [review]
bug-1136125-v1.patch
Review of attachment 8568518 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8568518 -
Flags: review?(dkl) → review+
|
|
||
Updated•11 years ago
|
Flags: approval?
Target Milestone: --- → Bugzilla 6.0
|
|
Assignee | |
Comment 5•11 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
ee27d53..74fb163 master -> master
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•