1136163 - Content can set location.href to about:reader? urls and check for items in the reading list

Status: RESOLVED INVALID

(Toolkit :: Reader Mode, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 39.0a1 20150224030228 on Windows 8.1

Content can set location.href to about:reader? urls and check for items in the reading list.

Steps to reproduce:
1. Enable reader view with reader.parse-on-load.enabled = true
2. Load https://wiki.mozilla.org/Main_Page
3. Open Scratchpad.
4. Paste and execute: location.href="about:reader?url=" +encodeURIComponent("http://www.heise.de/newsticker/meldung/PrivDog-torpediert-die-Web-Sicherheit-im-Namen-der-Privatsphaere-2557756.html")
Actual result: Reader view gets loaded and wiki.mozilla.org loaded shortly after that (because item hasn't been found in Reader)
5. Open a new tab and visit http://www.heise.de/newsticker/meldung/PrivDog-torpediert-die-Web-Sicherheit-im-Namen-der-Privatsphaere-2557756.html
6. Add it to reader by clicking onto the reader icon in the location bar.
7. Switch back to the wiki.mozilla.org tab.
8. Again paste and execute: location.href="about:reader?url=" +encodeURIComponent("http://www.heise.de/newsticker/meldung/PrivDog-torpediert-die-Web-Sicherheit-im-Namen-der-Privatsphaere-2557756.html")
Actual result: This time the reader view remains.

Expected result:
about:reader never gets loaded

Comment 1

[:Margaret Leibovic]

I'm a bit confused by these STR... whether or not a page loads in about:reader shouldn't have anything to do with whether or not an item is in your reading list.

Opening about:reader?url=... will always just load that URL in about:reader, provided that the URL is reader-mode-able. If we don't have a pre-parsed article (e.g. when we show the reader toolbar button), we'll just do an XHR to download the article content, which is why you see the "Loading..." message.

However, nothing is currently hooked up to cache the article content, so even if the URL was added to your reading list, if it's not open in a tab, we will always download it.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

I can't reproduce anymore the behavior observed earlier today: Calling the video url showed "Loading..." and then returned to the previous page.