[System] Trusted UI css properties are breaking MobileID dialog

RESOLVED FIXED in Firefox OS master

Status

Firefox OS
Gaia::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: borjasalguero, Assigned: borjasalguero)

Tracking

({regression})

unspecified
2.2 S7 (6mar)
ARM
Gonk (Firefox OS)
regression

Firefox Tracking Flags

(b2g-v2.2 unaffected, b2g-master fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

3 years ago
Created attachment 8568561 [details]
MobileID Dialog issue

When the MobileID dialog is shown, trusted UI appears as 'visibility: hidden', but the the container is pushing the content, so the MobileID UI is not working as expected.
(Assignee)

Updated

3 years ago
Assignee: nobody → borja.bugzilla
Created attachment 8568566 [details] [review]
[gaia] borjasalguero:fix_mobileid_dialog > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Created attachment 8568568 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/28415
Attachment #8568568 - Flags: review?(alive)
(Assignee)

Updated

3 years ago
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
[Blocking Requested - why for this release]: regression

Checking latest 2.2 build, the issue does NOT reproduce in 2.2 branch
blocking-b2g: --- → 3.0?
status-b2g-v2.2: --- → unaffected
Keywords: regression
Comment on attachment 8568568 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/28415

Hi Borja, mind explaining more why this fixes it? I don't see the difference between visibility:hidden and display:none here..
Flags: needinfo?(borja.bugzilla)
(Assignee)

Comment 5

3 years ago
Created attachment 8570366 [details]
MobileID working properly

When changing visibility:hidden to display:none in "trustedui-container".
Flags: needinfo?(borja.bugzilla)
(Assignee)

Comment 6

3 years ago
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #4)
> Comment on attachment 8568568 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/28415
> 
> Hi Borja, mind explaining more why this fixes it? I don't see the difference
> between visibility:hidden and display:none here..

Hi Alive! When testing MobileID I've just realized that there is a big 'empty' gap in the top (check [1]), which is pushing the content to the bottom, and actually is hiding the button in the footer. The element which is producing this gap is 'trustedui-container', so I've changed visibility:hidden to display:none through WebIDE and you can see the result in [2], which is working properly.
It seems that the 'trustedui-container' is keeping a height of 50px, so changing the visibility is just 'hiding' the content to the user, but the element is keeping the same space as when is shown (that's why the content is pushed and we can see the result in [1]). With display:none the element is not keeping the original dimensions, so the result is the same as if the element was not there.
I hope it helps!


[1] https://bug1136175.bugzilla.mozilla.org/attachment.cgi?id=8568561
[2] https://bug1136175.bugzilla.mozilla.org/attachment.cgi?id=8570366
Flags: needinfo?(alive)
Comment on attachment 8568568 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/28415

Thanks for explanation.
Flags: needinfo?(alive)
Attachment #8568568 - Flags: review?(alive) → review+
(Assignee)

Comment 8

3 years ago
Thanks Alive!
Gaia master: https://github.com/mozilla-b2g/gaia/commit/af660476962f0b1aa67af16cf8cc3c0d7533a9d5
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Clearing the nomination as the patch has already landed in master
blocking-b2g: 3.0? → ---
status-b2g-master: --- → fixed
Target Milestone: --- → 2.2 S7 (6mar)
You need to log in before you can comment on or make changes to this bug.