bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Do not add isDefaultBrowser to Telemetry Environment on Android.

RESOLVED FIXED in Firefox 39

Status

Firefox Health Report
Client: Desktop
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Dexter, Assigned: Dexter)

Tracking

unspecified
Firefox 39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [ready])

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

3 years ago
Until bug 1134186 lands, just log an error if |_isDefaultBrowser| fails and don't log the exceptions.
(Assignee)

Updated

3 years ago
Assignee: nobody → alessio.placitelli
Blocks: 1134269
Status: NEW → ASSIGNED
Summary: |TelemetryEnvironment._isDefaultBrowser| should not spamm test logs with exceptions. → |TelemetryEnvironment._isDefaultBrowser| should not spam test logs with exceptions.
(Assignee)

Comment 1

3 years ago
Created attachment 8568636 [details] [diff] [review]
bug1136199.patch
Attachment #8568636 - Flags: review?(gfritzsche)
(Assignee)

Comment 2

3 years ago
Created attachment 8568637 [details] [diff] [review]
bug1136199.patch - v2

We don't need to remove the exceptions from the logs after the first check.
Attachment #8568636 - Attachment is obsolete: true
Attachment #8568636 - Flags: review?(gfritzsche)
Attachment #8568637 - Flags: review?(gfritzsche)
Attachment #8568637 - Flags: review?(gfritzsche) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8568712 [details] [diff] [review]
bug1136199.patch - v3

To fix Android test failure, we drop isDefaultBrowser from the Environment if on Android.
Attachment #8568637 - Attachment is obsolete: true
Attachment #8568712 - Flags: review?(gfritzsche)
Attachment #8568712 - Flags: review?(gfritzsche) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8568742 [details] [diff] [review]
bug1136199.patch - v4

Changed the commit message.
Attachment #8568712 - Attachment is obsolete: true
Attachment #8568742 - Flags: review+
(Assignee)

Updated

3 years ago
Summary: |TelemetryEnvironment._isDefaultBrowser| should not spam test logs with exceptions. → Do not add isDefaultBrowser to Telemetry Environment on Android.
Whiteboard: [ready]
https://hg.mozilla.org/mozilla-central/rev/8a7c51d11500
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
You need to log in before you can comment on or make changes to this bug.