Closed Bug 1136241 Opened 6 years ago Closed 6 years ago

[AccessFu] Make sure hints are localizeable.

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: yzen, Assigned: yzen)

Details

Attachments

(1 file)

1136241 patch v1
3.52 KB, patch
eeejay
: review+
Details | Diff | Splinter Review 
At the moment when we generate a hint string, it might contain spaces because of the role strings. We need to squash them and replace ' ' with '' where possible, similar to what OutputGenerator does.
Attached patch 1136241 patch v1 — — Splinter Review
Attachment #8568661 - Flags: review?(eitan)
Comment on attachment 8568661 [details] [diff] [review]
1136241 patch v1

Review of attachment 8568661 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right, good catch on the non-global replace.
Attachment #8568661 - Flags: review?(eitan) → review+
https://hg.mozilla.org/mozilla-central/rev/18365d823fdf
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.