[AccessFu] Make sure hints are localizeable.

RESOLVED FIXED in Firefox 39

Status

()

Product:
Core
Component:
Disability Access APIs
Status:
RESOLVED FIXED
Reported:
4 years ago
Modified:
4 years ago

People

(Reporter: yzen, Assigned: yzen)

Tracking

Version:
unspecified
Target:
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

1136241 patch v1
3.52 KB, patch
eeejay
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
4 years ago 
At the moment when we generate a hint string, it might contain spaces because of the role strings. We need to squash them and replace ' ' with '' where possible, similar to what OutputGenerator does.
(Assignee)

Comment 1

•
4 years ago 
Created attachment 8568661 [details] [diff] [review]
1136241 patch v1
Attachment #8568661 - Flags: review?(eitan)

Comment 2

•
4 years ago 
Comment on attachment 8568661 [details] [diff] [review]
1136241 patch v1

Review of attachment 8568661 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right, good catch on the non-global replace.
Attachment #8568661 - Flags: review?(eitan) → review+

Comment 4

•
4 years ago 
https://hg.mozilla.org/mozilla-central/rev/18365d823fdf
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.