1136253 - Request URL in inspector pane needs lighter text in dark mode

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: Screen Shot 2015-02-24 at 10.08.50 AM.png

See image

Comment 1

[Wickie Lee [:Robocrypt]]

I would like to work on this bug. But am new to this. Some guidance would be appreciated.

Comment 2

[Giovanny Gongora [:gioyik]]

Thanks for joining Bugzilla and the initiative to fix this bug. First visit the Hacking Devtools page [1], it will guide you to get a copy of the source code and prepare your environment to start working. After you are done with the first step, check this line [2] on you source code. First, thats the file you need to modify and second just add a CSS new rule for the dark theme after [2] rule.

.theme-dark .tabpanel-summary-value {
  color: var(--theme-selection-color);
}

Be sure to check before submit a patch, the color has changed as requested. In Hacking Devtools page [1] there's some guidance about how to submit a patch. If you have questions or need more info to fix this bug feel free to ask on irc #devtools (irc.mozilla.org) or commenting here (use the 'request more information' feature, so you will get a soon answer).

[1] https://wiki.mozilla.org/DevTools/Hacking
[2] https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/devtools/netmonitor.inc.css#497

P.S Jordan, I hope not to have a problem for respond before you. If yes, sorry about it

Comment 3

[Vaibhav Bhosale]

Hey,
I am interested to work on this bug. I have pulled the latest repository.
And also made the changed you mentioned above. But how do I know if the color has actually changed.
Thank You!

Regards,
Vaibhav

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Thanks Giovanny, sounds good! And thanks Wickie for offering to check this out! Let me or Giovanny know if you have any other questions.

Vaibhav, looks like Wickie got it first, sorry!

Comment 5

[Wickie Lee [:Robocrypt]]

Attachment: theme_dark.patch

I added the code to correct the dark theme.

Comment 6

[Wickie Lee [:Robocrypt]]

Thank you for all of your help guys! I went ahead and added the code and made a patch file. Relatively confident that I did it right. Only thing is that I was not quite sure how to check if it was fixed after I built it with the change. Sorry if that seems extremely noob-like...

Comment 7

[Giovanny Gongora [:gioyik]]

Hi Wickie,

Thanks for the patch! The changes you made were for NetMonitor [0], and the specific part of the change is here [1]. First be sure to change the theme to dark in Devtools [2], and compare what you see on [1] section in your build with the screenshot that Jordan attached at the beginning of this bug.

The text next to "Request URL" should be lighter.

If you need help, let let us know.

[0] https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor
[1] https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor#Network_request_details
[2] https://developer.mozilla.org/en-US/docs/Tools/Tools_Toolbox#Choose_DevTools_theme

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8569649 [details] [diff] [review]
theme_dark.patch

Review of attachment 8569649 [details] [diff] [review]:
-----------------------------------------------------------------

Just applied the patch and seems to have done the trick!

Comment 9

[Jordan Santell [:jsantell] [@jsantell]]

Thanks Giovanny and Wickie for all the help! Marking this as ready to be checked in.

Comment 10

[Giovanny Gongora [:gioyik]]

Wickie congratulations for your first patch! :)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/6a4698e03d5e

Thanks for the patch, Wickie! One request, please try to include a commit message in your patch when requesting checkin. The link below includes some guidance:
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 12

[Wickie Lee [:Robocrypt]]

Sorry about that! Still getting used to the whole process. Thanks for the help guys and I will make sure to do commit messages from here on out.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6a4698e03d5e