Closed Bug 1136258 Opened 9 years ago Closed 9 years ago

Update sockit-to-me to work with node 0.12

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jlal, Assigned: aus)

Details

Attachments

(1 file)

Pull Request - Update sockit-to-me for node 0.12
51 bytes, text/x-github-pull-request
jlal
: review+
Details | Review 
Underlying v8 has changed so our interfaces need to be updated.
Can you take a look sometime soon?
Flags: needinfo?(aus)
Out of curiosity, do we have a log of the compilation failures handy already? No worries if not. I'll have a chance to look at this Thursday or Friday.
Assignee: nobody → aus
Flags: needinfo?(aus)
We'll try and maintain compatibility between node 0.10 and 0.12 with this update also.
Pretty straightforward. A few finishing touches left, will set review flag when they're in.
Status: NEW → ASSIGNED
Attachment #8573438 - Flags: review?(jlal)
This pull request also revs the version up to 0.3.0.
Comment on attachment 8573438 [details] [review]
Pull Request - Update sockit-to-me for node 0.12

0.10 and 0.12 work so ++ lgtm
Attachment #8573438 - Flags: review?(jlal) → review+
Commit (master): https://github.com/mozilla-b2g/sockit-to-me/commit/4a6a40fc07061a83a68757a656e0593e1dd41890

Pushed 0.3.0 to npmjs.org.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: