The treeclosure hook reason should be clearer in the message

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Current example output:

[~/src/inbound]$ hg push try -f
pushing to ssh://hg.mozilla.org/try/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 17 changesets with 34 changes to 65 files (+1 heads)
remote: Tree try is CLOSED! (https://treestatus.mozilla.org/try?format=json) - Bug 1136195 - Frequent timeouts
remote:
remote:
remote: ************************** ERROR ****************************
remote: To push despite the closed tree, include "CLOSED TREE" in your push comment
remote: *************************************************************
remote:
remote:
remote: transaction abort!
remote: rollback completed
remote: abort: pretxnchangegroup.a_treeclosure hook failed

Suggestion:
[~/src/inbound]$ hg push try -f
pushing to ssh://hg.mozilla.org/try/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 17 changesets with 34 changes to 65 files (+1 heads)
remote:
remote:
remote: ************************** ERROR ****************************
remote: Tree try is CLOSED! (https://treestatus.mozilla.org/try?format=json) - Bug 1136195 - Frequent timeouts
remote: To push despite the closed tree, include "CLOSED TREE" in your push comment
remote: *************************************************************
remote:
remote:
remote: transaction abort!
remote: rollback completed
remote: abort: pretxnchangegroup.a_treeclosure hook failed
(Assignee)

Updated

4 years ago
Assignee: nobody → emorley
(Assignee)

Comment 1

4 years ago
Created attachment 8570937 [details] [diff] [review]
make the tree closure reason clearer in the console
Attachment #8570937 - Flags: review?(gps)
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED

Updated

4 years ago
Attachment #8570937 - Flags: review?(gps) → review+
(Assignee)

Comment 2

4 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/5f2c90efe62a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Depends on: 1138856
You need to log in before you can comment on or make changes to this bug.