1136277 - The try syntax hook is too chatty

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Ed Morley [:emorley]]

On it's own, four lines isn't much. But by the time you include the print_pushlog url hook, the tree closure hook and everything else it gets a bit much.

Current:

[~/src/inbound]$ hg push try -f
...
remote: Looks like you used try syntax, going ahead with the push.
remote: If you don't get what you expected, check http://trychooser.pub.build.mozilla.org/
remote: for help with building your trychooser request.
remote: Thanks for helping save resources, you're the best!
...

Suggested:
[~/src/inbound]$ hg push try -f
...
remote: For help generating Try syntax, see: http://trychooser.pub.build.mozilla.org/
remote: Thanks for helping save resources, you're the best!

Or even no output at all - given that the failure case (ie bad syntax) is probably the better time to link to the trychooser site.

Comment 1

[Ed Morley [:emorley]]

Attachment: make try_mandatory less chatty when the syntax is correct

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8570917 [details] [diff] [review]
make try_mandatory less chatty when the syntax is correct

Review of attachment 8570917 [details] [diff] [review]:
-----------------------------------------------------------------

I agree that this message is overly verbose.

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/6a620280410a