Foundation Security Advisory importer should not fail if it encounters a parse error

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: pmac, Assigned: pmac)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Currently if one of the updated files has an error when importing it causes the whole import command to fail at that point. This leaves things in an odd state since the importer gets the list of files to import from the list from git of what files changed when it did the `git pull`. Since the next run nothing else will have changed in git, but some files weren't imported on the failed run, those files are in limbo and will only be imported if we run the command with the --force flag.

The command should only skip files that actually error. It's fine to skip these until they're fixed, at which point they'll be in the updated list again from git and the import will be retried.
Created attachment 8568713 [details] [review]
Link to Github pull-request: https://github.com/mozilla/bedrock/pull/2770

This should fix it.

Comment 2

4 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/59b7b0991da14255cb4a4d1bb67c028bf65af601
Fix bug 1136307: Catch all errors and report exceptions for MFSA import.

https://github.com/mozilla/bedrock/commit/5bcae2ab1bcdd78b11aa4b00f7b3ad5cf7a06340
Merge pull request #2770 from pmclanahan/mofo-mfsa-importer-no-error-1136307

Fix bug 1136307: Catch all errors and report exceptions for MFSA import.

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.