TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-weak-set.test adding non object or null item | only non-null object are allowed - "true is not a non-null object" matches "/^value is not a non-null object/"

RESOLVED FIXED

Status

P1
blocker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: evold, Assigned: evold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

TEST-START | addon-sdk/tests/test-weak-set.test adding non object or null item
TEST-PASS | addon-sdk/tests/test-weak-set.test adding non object or null item | only non-null object are allowed
TEST-PASS | addon-sdk/tests/test-weak-set.test adding non object or null item | only non-null object are allowed
TEST-PASS | addon-sdk/tests/test-weak-set.test adding non object or null item | only non-null object are allowed
TEST-PASS | addon-sdk/tests/test-weak-set.test adding non object or null item | only non-null object are allowed
TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-weak-set.test adding non object or null item | only non-null object are allowed - "true is not a non-null object" matches "/^value is not a non-null object/"
TEST-INFO | Traceback (most recent call last):
  File "resource://gre/modules/Promise-backend.js", line 688, in this.PromiseWalker.scheduleWalkerLoop/<
    DOMPromise.resolve().then(() => this.walkerLoop());
  File "resource://gre/modules/Promise-backend.js", line 746, in this.PromiseWalker.walkerLoop
    this.handlers.shift().process();
  File "resource://gre/modules/Promise-backend.js", line 867, in Handler.prototype.process
    nextValue = this.onResolve.call(undefined, nextValue);
  File "resource://extensions.modules.1c28b511-9f9b-4b9f-a8c5-1150f420394d-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 522, in startMany/runNextTest/<
    self.start({test: test, onDone: runNextTest});
  File "resource://extensions.modules.1c28b511-9f9b-4b9f-a8c5-1150f420394d-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 559, in start
    this.test.testFunction(this);
  File "resource://extensions.modules.1c28b511-9f9b-4b9f-a8c5-1150f420394d-at-jetpack.commonjs.path/sdk/test.js", line 75, in null
    test(assert);
  File "resource://1c28b511-9f9b-4b9f-a8c5-1150f420394d-at-jetpack/addon-sdk/tests/test-weak-set.js", line 145, in exports["test adding non object or null item"]
    assert.throws(() => {
  File "resource://extensions.modules.1c28b511-9f9b-4b9f-a8c5-1150f420394d-at-jetpack.commonjs.path/sdk/test/assert.js", line 309, in throws
    this.fail(failure);
  File "resource://extensions.modules.1c28b511-9f9b-4b9f-a8c5-1150f420394d-at-jetpack.commonjs.path/sdk/test/assert.js", line 88, in fail
    this._log.fail(message);
  File "resource://extensions.modules.1c28b511-9f9b-4b9f-a8c5-1150f420394d-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 104, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.1c28b511-9f9b-4b9f-a8c5-1150f420394d-at-jetpack.commonjs.path/sdk/test/harness.js", line 543, in testMessage
    this.trace();
TEST-END | addon-sdk/tests/test-weak-set.test adding non object or null item
Assignee: nobody → evold
Priority: -- → P1
Attachment #8568707 - Flags: review?(jsantell) → review+

Comment 2

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/032c8c39287cbf8b5e443a00dc94b87850870123
Bug 1136315 Using /^\w+ is not a non-null object/ instead of /^value is not a non-null object/ becuase the error message appears to have changed on the platform.

https://github.com/mozilla/addon-sdk/commit/c855a89c88f52245604dfd5864998a11fccfa0f6
Merge pull request #1875 from erikvold/1136315

Bug 1136315 Using /^\w .../ instead of /^value .../ r=jsantell
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.