Closed
Bug 1136341
Opened 10 years ago
Closed 10 years ago
[e10s] Breakpoints don't trigger until a new window is opened/closed
Categories
(DevTools :: Debugger, defect)
Tracking
(e10s+, firefox39 fixed)
RESOLVED
FIXED
Firefox 39
People
(Reporter: gw280, Assigned: jlong)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
1.23 KB,
patch
|
Details | Diff | Splinter Review |
Steps to reproduce:
- open a new e10s window "A"
- open the browser toolbox
- set a breakpoint here: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml?from=tabbrowser.xml#5470
- switch tabs, nothing happens
- open new e10s window "B"
- close new e10s window "B"
- switch tabs on window "A" again
- -> breakpoint now triggers correctly
This may not be e10s specific, but the breakpoint there is in code only executed in e10s windows.
Expected:
Breakpoint correctly triggers without having to open new e10s window
Assignee | ||
Comment 1•10 years ago
|
||
I can take a look at this later this week. Maybe it's something to do with our script store, and somehow opening the new window makes it load all the scripts into our debugger server or something?
This sounds potentially related to bug 1107656 where connecting to both an e10s window and browser toolbox at the time same time causes RDP message to get misrouted.
See Also: → 1107656
Comment 3•10 years ago
|
||
James, if this is indeed an E10s bug, then this is one I could use your help with! Let me know whether you'll be able to look into this.
Blocks: dbg-breakpoint
Summary: breakpoints don't trigger until a new window is opened/closed → [e10s] Breakpoints don't trigger until a new window is opened/closed
Updated•10 years ago
|
tracking-e10s:
--- → +
Assignee | ||
Comment 4•10 years ago
|
||
I'll make this a priority since e10s is supposed to be uplifted in a couple weeks
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jlong
Assignee | ||
Comment 5•10 years ago
|
||
I just tried it with the patch from bug 1107656 and it still happens. I'll dig around some more.
Assignee | ||
Comment 6•10 years ago
|
||
Super small patch. I don't think this was e10s related. We weren't marking inline scripts in XUL files as actually inline, which messed up how we handle source actors for them.
Attachment #8574786 -
Flags: review?(ejpbruel)
Comment 7•10 years ago
|
||
Comment on attachment 8574786 [details] [diff] [review]
1136341.patch
Review of attachment 8574786 [details] [diff] [review]:
-----------------------------------------------------------------
No comments here!
Attachment #8574786 -
Flags: review?(ejpbruel) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 11•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•