1136386 - python client: Logs credentials when debugging is enabled

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Michael Shal [:mshal]]

If DEBUG_TASKCLUSTER_CLIENT is set in the environment, the python client prints the clientId+accessToken to the screen. We should either remove this debug line (I think it's log.debug(o) in BaseClient:__init__()), or find some other way to log useful information (permission errors, retries, etc) from mozharness.

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

Attachment: Github PR

Log all options except "credentials".

As it probably makes a lot of sense to log the options passed in. Just in case someone changes the `base_url` or something...

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 8568801 [details] [review]
Github PR

>>> import taskcluster
>>> a = taskcluster.Auth()
credentials key scrubbed from logging output
credentials key scrubbed from logging output
{'maxRetries': 5, 'baseUrl': u'https://auth.taskcluster.net/v1', 'signedUrlExpiration': 900}
{'maxRetries': 5, 'baseUrl': u'https://auth.taskcluster.net/v1', 'signedUrlExpiration': 900}

Merged with a slight modification to the logic to print a message about the fact that we're scrubbing credentials

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8568801 [details] [review]
Github PR

clearing r? as jhford decided to merge it.

Comment 4

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...