1136392 - [Settings][Privacy Controls] The city name Dumont d'Urville is misspelled as DumontDUrville in the Custom Location city picker

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Joshua Mitchell (Inactive)]

Attachment: IMG_0001.jpg

Description:
 In Privacy Controls you can set a custom location in Location Accuracy. This feature will take you to a list (picker) of Region / City. Under the Antarctica the city of Dumont d'Urville has several formatting errors.

DumontDUrville vs. Dumont d'Urville

Repro Steps:
1) Update a Flame to 20150224010314
2) Launch Settings > Privacy Controls > Location Accuracy and set Location adjustment to custom location.
3) Set custom location to Antarctica / Dumont d'Urville

Actual:
DumontDUrville

Expected:
Dumont d'Urville

Environmental Variables:
Device: Flame Master (KK - Nightly - Full Flash - 319mem)
Build ID: 20150224010314
Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e
Gecko: 368c62292249
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 100%
See attached: screenshot

Comment 1

[Joshua Mitchell (Inactive)]

This issue also occurs in 2.2  (Privacy Controls not present prior to 2.2)

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150224002637
Gaia: 8e98fe665f3821d10d4d982cbb14cbe5b94d0be5
Gecko: 2b70d9d62799
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision and assignment.

Comment 3

[Gerry Chang [:gchang]]

Hi Marta,
Can you help on this?

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] martasect:Bug_1136392 > mozilla-b2g:master

Comment 5

[marta]

Proposed patch. Requesting review from pbylenga

Comment 6

[Peter Bylenga [:PBylenga]]

Comment on attachment 8570733 [details] [review]
[gaia] martasect:Bug_1136392 > mozilla-b2g:master

Theo can you or a peer handle this review?

Comment 7

[Théo Chevalier]

Comment on attachment 8570733 [details] [review]
[gaia] martasect:Bug_1136392 > mozilla-b2g:master

LGTM here as well, but again, Autolander won't land if I give it an r+, forwarding to Evelyn ;)

Comment 8

[Evelyn Hung]

Comment on attachment 8570733 [details] [review]
[gaia] martasect:Bug_1136392 > mozilla-b2g:master

City name updated in a json file should be fine.

Comment 9

[Théo Chevalier]

Thanks Evelyn, trying to land

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d292d89970b83794e9dd7b3ea6edb8bea4ca6af0

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 approval on this patch when you get a chance.

Comment 12

[marta]

how do I do it?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Click the Details link on your attachment, set the "approval‑gaia‑v2.2" dropdown to '?', and fill out the questions in the textbox.

Comment 14

[bhavana bajaj [:bajaj]]

(In reply to marta from comment #12)
> how do I do it?

HI Marta,

I'll approve this patch as an exception although you've not filled in the approval request form, given I checked the patch myself and is a low risk risk change, but for next time around please do the fill the comments in so we understand the risk and testing done of the patch you are trying to land.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/7978800ed864886b23e3c0f1c138b6adde31734b

Comment 16

[Gerry Chang [:gchang]]

Verified @ 
Gaia-Rev        a6b2d3f8478ec250beb49950fecbb8a16465ff6f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/18619f8f6c5c
Build-ID        20150315162500
Version         37.0
Device-Name     flame
FW-Release      4.4.2

Comment 17

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 build.

Actual Results: Dumont d'Urville is spelled correctly.

Environmental Variables:
Device: Flame 3.0 KK (Full Flash) (319 MB)
BuildID: 20150317073344
Gaia: 738987bd80b0ddb4ccf853855388c2627e19dcc1
Gecko: 008b3f65a7e0
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0