Closed Bug 1136437 Opened 9 years ago Closed 9 years ago

Tab buttons are not labeled for accessibility

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S7 (6mar)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Keywords: access, late-l10n)

Attachments

(1 file)

[gaia] eeejay:bug-1136437 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
squib
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
They have icons, but no localizeable text label.
Attachment #8568849 - Flags: review?(squibblyflabbetydoo)
QA Contact: eitan
(In reply to Autolander from comment #1)
> Created attachment 8568849 [details] [review]
> [gaia] eeejay:bug-1136437 > mozilla-b2g:master

Should be assignee?
Assignee: nobody → eitan
QA Contact: eitan → nobody
(In reply to Dominic Kuo [:dkuo] (2/16 - 2/23 CNY) from comment #2)
> (In reply to Autolander from comment #1)
> > Created attachment 8568849 [details] [review]
> > [gaia] eeejay:bug-1136437 > mozilla-b2g:master
> 
> Should be assignee?

Yes, thanks!
Comment on attachment 8568849 [details] [review]
[gaia] eeejay:bug-1136437 > mozilla-b2g:master

Looks good to me, thanks!
Attachment #8568849 - Flags: review?(squibblyflabbetydoo) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8568849 [details] [review]
[gaia] eeejay:bug-1136437 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Tabs will not be perceivable to screen reader users
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): No risk
[String changes made]: New labels introduced for tabs in screen reader.
Attachment #8568849 - Flags: approval-gaia-v2.2?
Attachment #8568849 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: