1136450 - Pre-packaging runs for all projects

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

After bug 1124501, it looks like we *always* pre-package, even for projects with no build step.

This means we show the logs panel for many projects where it's not needed.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: bz://1136450/jryans

/r/4287 - Bug 1136450 - WebIDE packaging check did not function correctly. r=ochameau

Pull down this commit:

hg pull review -r 33d7f9574d5154ba204279962fa0298ddd81aad6

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8568883 [details]
MozReview Request: bz://1136450/jryans

Good catch! I'm mostly using gaia apps these days...

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://hg.mozilla.org/integration/fx-team/rev/e460ff7b19b9

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e460ff7b19b9

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8568883 [details]
MozReview Request: bz://1136450/jryans

Approval Request Comment
[Feature/regressing bug #]: Bug 1124501
[User impact if declined]: WebIDE will show a confusing log screen for every project, when it is only needed for a few
[Describe test coverage new/current, TreeHerder]: On m-c
[Risks and why]: Low, only changes single check in WebIDE
[String/UUID change made/needed]: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/72eb85afdde6

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1136450 - WebIDE packaging check did not function correctly. r=ochameau