Closed Bug 1136469 Opened 9 years ago Closed 9 years ago

Remove arrow from Doorhanger

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox39 verified)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- verified

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(4 files, 1 obsolete file)

To be consistent with the new Doorhanger mocks, we will remove the doorhanger arrow.
Blocks: 1124711
Attached file MozReview Request: bz://1136469/liuche (obsolete) —
/r/4337 - Bug 1136469 - Remove arrow from doorhanger.
/r/4339 - Testing out shadows. Gradient difficult to fine-tune.

Pull down these commits:

hg pull review -r 2d71cb99ecb35cd6f03edd0344db902895fb80c1
Doorhanger removed and anchoring fixed - need some work on making a shadow in xml so we can have rounded corners.
Attachment #8569573 - Flags: review?(margaret.leibovic)
Comment on attachment 8569573 [details]
MozReview Request: bz://1136469/liuche

/r/4337 - Bug 1136469 - Remove arrow from doorhanger. r=margaret

Pull down this commit:

hg pull review -r 445f6e3b04a43ca2594fd92a6bde5f98b6791ff8
There are a few more code removals that I need to make: note to self, make a part 2.
Attachment #8569573 - Flags: review?(margaret.leibovic)
Comment on attachment 8569573 [details]
MozReview Request: bz://1136469/liuche

https://reviewboard.mozilla.org/r/4335/#review3781

I assume you have tested this on phones and tablets, in both portrait and landscape. If all those combinations look good, we can go ahead and land this.

::: mobile/android/base/resources/values/colors.xml
(Diff revision 2)
> +  <color name="background_neutral">#EBEBF0</color>

Is this one of the color palette colors?

::: mobile/android/base/widget/AnchoredPopup.java
(Diff revision 2)
> +    View mAnchor;

Doing a quick code search, I think this can be private.

Also, did you do an `hg mv` and then start editing things? I think that's what we should do here, but IIRC reviewboard doesn't do a good job showing this...

::: mobile/android/base/widget/AnchoredPopup.java
(Diff revision 2)
> +        // We want the doorhanger to be offset from the base of the urlbar which is the anchor.

This makes an assumption about what the anchor is. Will the anchor always be the same for the SiteIdentityPopup and DoorHangerPopup? We may want to more explictly document this assumption in a class comment about AnchoredPopup, in case we ever want to use this for something else.
Comment on attachment 8569573 [details]
MozReview Request: bz://1136469/liuche

https://reviewboard.mozilla.org/r/4335/#review3783

Ship It!
Attachment #8569573 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/bcc59a4e3064
Target Milestone: --- → Firefox 39
https://hg.mozilla.org/mozilla-central/rev/bcc59a4e3064
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attached image Doorhanger-no-arrow
Tested with:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 39.0a1 (2015-03-06)
I've attached a screenshot with the new doorhanger that is displayed without arrow.

If I rotate the device from portrait to landscape, the mixed content blocking doorhanger and the security information doorhanger disappear. As for the geolocation, password and pop-up blocker doorhanger they don't disappear. Shouldn't be a consistency among all types of doorhangers?
I will mark status status-firefox39 as verified since doorhangers are displayed without arrow.
Thanks for verifying, Theodora, I didn't see this until now.

I filed bug 1141904 for unifying site information doorhangers with "all other doorhangers" (like geo, passwords, etc) - they are not the same right now but we do want to unify them. Thanks!
Attachment #8569573 - Attachment is obsolete: true
Attachment #8619585 - Flags: review+
Attachment #8619586 - Flags: review+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: