1136549 - Replace evt.device.name with evt.deviceName when accessing BluetoothPairingEvent

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jocelyn Liu [:jocelyn] [:joliu]]

Bug 1127670 revise the webidl of BluetoothPairingEvent by replacing
attribute BluetoothDevice device with attribute DOMString deviceName.
This bug is to revise bluetooth app to use evt.deviceName instead of evt.device.name to access the remote device name.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] yrliou:Bug1136549 > mozilla-b2g:master

Comment 2

[Jocelyn Liu [:jocelyn] [:joliu]]

Correct the component

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8568980 [details] [review]
[gaia] yrliou:Bug1136549 > mozilla-b2g:master

Hi Ian,

This patch is to revise how bluetooth app access the device name from the pairing event.
Updated API doc is at https://wiki.mozilla.org/B2G/Bluetooth/WebBluetooth-v2/BluetoothPairingEvent#BluetoothPairingEvent.
Could you help to review my gaia patch?

Thanks,
Jocelyn

Comment 4

[[e-mail], [e-mail]]

Comment on attachment 8568980 [details] [review]
[gaia] yrliou:Bug1136549 > mozilla-b2g:master

r+ with me. Since API interface changed, thanks for Jocelyn's help in part of Gaia work.:) Looks unit test works fine.

Comment 5

[[e-mail], [e-mail]]

I leave a note in GitHub for the format name of pull request.

Comment 6

[Jocelyn Liu [:jocelyn] [:joliu]]

Thanks for your time, Ian!

Comment 7

[[e-mail], [e-mail]]

We can close the issue since the pr is landed.

Gaia/master:  7d080a946a70a6bf3340d277fb662c4a6bc888be