Closed
Bug 1136584
Opened 9 years ago
Closed 9 years ago
Jit does not run at all for evalInWorker scripts in the JS shell
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
Details
Attachments
(1 file)
5.25 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Looks like the JIT is never triggered at all for evalInWorker scripts in the JS shell. This makes testing the SAB/Atomics work harder (forces it into the browser).
Assignee | ||
Comment 1•9 years ago
|
||
Runtime options not properly set on the worker runtime.
Assignee | ||
Comment 2•9 years ago
|
||
I'm guessing more could be done, eg, copying over more memory settings, but this at least enables the JIT.
Attachment #8569067 -
Flags: review?(hv1989)
Comment 3•9 years ago
|
||
Comment on attachment 8569067 [details] [diff] [review] Copy compiler options from the main thread Review of attachment 8569067 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me. But I even didn't know we could run workers in the shell. That is exciting!!! So forwarding to Brian, since he added that code.
Attachment #8569067 -
Flags: review?(hv1989) → review?(bhackett1024)
Updated•9 years ago
|
Attachment #8569067 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/75c2c9a3e09d
https://hg.mozilla.org/mozilla-central/rev/75c2c9a3e09d https://hg.mozilla.org/mozilla-central/rev/9b55a4690632
Assignee: nobody → lhansen
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•