Closed Bug 1136603 Opened 10 years ago Closed 10 years ago

[Stingray] expose isVisible and focus API for sleep_menu

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: suchiu, Assigned: johnhu)

References

Details

Attachments

(1 file, 2 obsolete files)

[gaia] huchengtw-moz:bug-1136603-v2 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
suchiu
: review+
Details | Review
1. isVisible API: Determine whether this UI is visible or not, and return z-index. 2. focus API: Focus the default elementin this UI.
No longer blocks: stingray-focus-fallback
Assignee: nobody → im
Comment on attachment 8569692 [details] [review] [gaia] huchengtw-moz:bug-1136603-sleep-menu-api > mozilla-b2g:master Sung Please review this patch.
Attachment #8569692 - Flags: review?(suchiu)
Comment on attachment 8569692 [details] [review] [gaia] huchengtw-moz:bug-1136603-sleep-menu-api > mozilla-b2g:master It's good!
Attachment #8569692 - Flags: review?(suchiu) → review+
merged to master: https://github.com/mozilla-b2g/gaia/commit/f1d53cc5d0468bb4f4090339deece5992d6c3528 gaia try is all green: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=224474822335
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
reverted: https://github.com/mozilla-b2g/gaia/commit/bbf019e63323848ee68fd517d4daff704c7c95d8 We have to change the API because it looks a little confusing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8569692 [details] [review] [gaia] huchengtw-moz:bug-1136603-sleep-menu-api > mozilla-b2g:master >https://github.com/mozilla-b2g/gaia/pull/28488
Attachment #8569692 - Attachment is obsolete: true
Attachment #8571126 - Attachment is obsolete: true
Comment on attachment 8571131 [details] [review] [gaia] huchengtw-moz:bug-1136603-v2 > mozilla-b2g:master Sung, I had changed the patch to use latest API.
Attachment #8571131 - Flags: review?(suchiu)
Comment on attachment 8571131 [details] [review] [gaia] huchengtw-moz:bug-1136603-v2 > mozilla-b2g:master Looks good to me!
Attachment #8571131 - Flags: review?(suchiu) → review+
merged to master: https://github.com/mozilla-b2g/gaia/commit/0a0c6008866510b88d9a75bd30fbd249bfea9b3c gaia try is all green: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=a15fc2908c60
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Blocks: 1136590
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: