[Stingray] expose isVisible and focus API for sleep_menu

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sungchiu, Assigned: johnhu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

3 years ago
1. isVisible API: Determine whether this UI is visible or not, and return z-index.
2. focus API: Focus the default elementin this UI.
(Reporter)

Updated

3 years ago
No longer blocks: 1136589
Assignee: nobody → im
Created attachment 8569692 [details] [review]
[gaia] huchengtw-moz:bug-1136603-sleep-menu-api > mozilla-b2g:master
Comment on attachment 8569692 [details] [review]
[gaia] huchengtw-moz:bug-1136603-sleep-menu-api > mozilla-b2g:master

Sung

Please review this patch.
Attachment #8569692 - Flags: review?(suchiu)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8569692 [details] [review]
[gaia] huchengtw-moz:bug-1136603-sleep-menu-api > mozilla-b2g:master

It's good!
Attachment #8569692 - Flags: review?(suchiu) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/f1d53cc5d0468bb4f4090339deece5992d6c3528

gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=224474822335
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Created attachment 8571126 [details] [review]
[gaia] mozilla-b2g:revert-28488-bug-1136603-sleep-menu-api > mozilla-b2g:master
reverted:
https://github.com/mozilla-b2g/gaia/commit/bbf019e63323848ee68fd517d4daff704c7c95d8

We have to change the API because it looks a little confusing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 8571131 [details] [review]
[gaia] huchengtw-moz:bug-1136603-v2 > mozilla-b2g:master
Comment on attachment 8569692 [details] [review]
[gaia] huchengtw-moz:bug-1136603-sleep-menu-api > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/28488
Attachment #8569692 - Attachment is obsolete: true
Attachment #8571126 - Attachment is obsolete: true
Comment on attachment 8571131 [details] [review]
[gaia] huchengtw-moz:bug-1136603-v2 > mozilla-b2g:master

Sung,

I had changed the patch to use latest API.
Attachment #8571131 - Flags: review?(suchiu)
(Reporter)

Comment 10

3 years ago
Comment on attachment 8571131 [details] [review]
[gaia] huchengtw-moz:bug-1136603-v2 > mozilla-b2g:master

Looks good to me!
Attachment #8571131 - Flags: review?(suchiu) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/0a0c6008866510b88d9a75bd30fbd249bfea9b3c

gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=a15fc2908c60
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Blocks: 1136590
You need to log in before you can comment on or make changes to this bug.