If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Stingray] expose isVisible and focus API for entry sheet

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: johnhu, Assigned: sungchiu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1. isVisible API: Determine whether this UI is visible or not, and return z-index.
2. focus API: Focus the default elementin this UI.
(Assignee)

Updated

3 years ago
Assignee: nobody → suchiu
(Assignee)

Updated

3 years ago
Duplicate of this bug: 1136604

Comment 2

3 years ago
Created attachment 8574501 [details] [review]
[gaia] sean2449:Bug_1136605 > mozilla-b2g:master
(Assignee)

Comment 3

3 years ago
Comment on attachment 8574501 [details] [review]
[gaia] sean2449:Bug_1136605 > mozilla-b2g:master

1. Add isVisible, getElement and focus API in Captive_Portal (for EntrySheet). Notifications are handled in interactive_notification.
2. To test this patch:
   a. Under build/config/tv/custom-prefs.js, add user_pref('captivedetect.canonicalContent', 'no\n');

   b. To test EntrySheet, we have to change line 36 ‘if (FtuLauncher.isFtuRunning())’ to ‘if (true || FtuLauncher.isFtuRunning())’
Attachment #8574501 - Flags: review?(im)
Comment on attachment 8574501 [details] [review]
[gaia] sean2449:Bug_1136605 > mozilla-b2g:master

Looks good.

Please find my comments at PR. We should include few lines of code to prevent multiple close function call.
Attachment #8574501 - Flags: review?(im) → review+
(Assignee)

Comment 5

3 years ago
Commit: https://github.com/mozilla-b2g/gaia/commit/2af946d09db6625e29cbc1c04bdd0b67c2acebef
Gaia-try(all green): https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=38e7312d616e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.