[Stingray] expose isVisible and focus API for interactive_notification

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sungchiu, Assigned: sungchiu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
1. isVisible API: Determine whether this UI is visible or not, and return z-index.
2. focus API: Focus the default elementin this UI.
(Assignee)

Updated

3 years ago
No longer blocks: 1136589
(Assignee)

Updated

3 years ago
Assignee: nobody → suchiu
Created attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8572998 - Flags: review?(im)
Comment on attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master

As we discussed offline, this patch breaks a feature.
Attachment #8572998 - Flags: review?(im)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master

The banner will now be focused when there are no buttons in it.
Attachment #8572998 - Flags: review?(im)
Comment on attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master

You forgot to update the bower components.
Attachment #8572998 - Flags: review?(im)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master

Update bower_component - smart-banner
Attachment #8572998 - Flags: review?(im)
Comment on attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master

Looks good to me.
Attachment #8572998 - Flags: review?(im) → review+
You need to log in before you can comment on or make changes to this bug.