Closed Bug 1136609 Opened 7 years ago Closed 7 years ago

[Stingray] expose isVisible and focus API for interactive_notification

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: suchiu, Assigned: suchiu)

References

Details

Attachments

(1 file)

1. isVisible API: Determine whether this UI is visible or not, and return z-index.
2. focus API: Focus the default elementin this UI.
No longer blocks: stingray-focus-fallback
Assignee: nobody → suchiu
Attachment #8572998 - Flags: review?(im)
Comment on attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master

As we discussed offline, this patch breaks a feature.
Attachment #8572998 - Flags: review?(im)
Comment on attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master

The banner will now be focused when there are no buttons in it.
Attachment #8572998 - Flags: review?(im)
Comment on attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master

You forgot to update the bower components.
Attachment #8572998 - Flags: review?(im)
Comment on attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master

Update bower_component - smart-banner
Attachment #8572998 - Flags: review?(im)
Comment on attachment 8572998 [details] [review]
[gaia] sean2449:Bug_1136609 > mozilla-b2g:master

Looks good to me.
Attachment #8572998 - Flags: review?(im) → review+
You need to log in before you can comment on or make changes to this bug.