[Stingray] expose isVisible and focus API for ime_menu

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sungchiu, Assigned: sungchiu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
1. isVisible API: Determine whether this UI is visible or not, and return z-index.
2. focus API: Focus the default elementin this UI.
(Assignee)

Updated

3 years ago
No longer blocks: 1136589
(Assignee)

Updated

3 years ago
Assignee: nobody → suchiu
Created attachment 8572977 [details] [review]
[gaia] sean2449:Bug_1136610 > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8572977 [details] [review]
[gaia] sean2449:Bug_1136610 > mozilla-b2g:master

1. IME Menu check is implemented in KeyboardManager. It's easier to test it by simply calling KeyboardManager._showImeMenu()
Attachment #8572977 - Flags: review?(im)
Comment on attachment 8572977 [details] [review]
[gaia] sean2449:Bug_1136610 > mozilla-b2g:master

Where is the code to add UI to focus manager? Have you filed another bug for this purpose?
Attachment #8572977 - Flags: review?(im)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8572977 [details] [review]
[gaia] sean2449:Bug_1136610 > mozilla-b2g:master

I have added focusManager.addUI, please help me to review this patch.
Attachment #8572977 - Flags: review?(im)
Comment on attachment 8572977 [details] [review]
[gaia] sean2449:Bug_1136610 > mozilla-b2g:master

Looks good to me. Thanks.
Attachment #8572977 - Flags: review?(im) → review+
(Assignee)

Comment 6

3 years ago
Commit: https://github.com/mozilla-b2g/gaia/commit/4020c3dd7a823b371d0e10403b53862d9a3aa616
Gaia-try (all green): https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=a520bd03a6d5
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.