1136612 - [Stingray] expose isVisible and focus API for crash_report

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[Sung Chiu[:sungchiu]]

1. isVisible API: Determine whether this UI is visible or not, and return z-index.
2. focus API: Focus the default elementin this UI.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] sean2449:Bug_1136612 > mozilla-b2g:master

Comment 2

[Sung Chiu[:sungchiu]]

Comment on attachment 8571880 [details] [review]
[gaia] sean2449:Bug_1136612 > mozilla-b2g:master

Please help me to review this patch.
There are two kinds of UI, crash-dialog(under dialog overlay) and system-banner(under screen), under crash report. Since we only interest in UIs that contain focusable elements, I made the following logic for isVisible, getOrder, focus API:
1. isVisible: If crash-dialog is visible, return true. If banner is shown and the button in the banner is also visible, return true.
2. getOrder: If crash-dialog is visible, return the z-index of it's parent (we only care about the z-index value under screen). If system-banners are visible, report the z-index value of lattest system-banner.
3. Focus: Focus 'send' report button for crash-dialog or button in system-banner.

Comment 3

[Sung Chiu[:sungchiu]]

Comment on attachment 8571880 [details] [review]
[gaia] sean2449:Bug_1136612 > mozilla-b2g:master

As John and I discussed earlier, we have to remove 'dialog-overlay' and move all it's children dialogs to 'screen'

Comment 4

[Sung Chiu[:sungchiu]]

Comment on attachment 8571880 [details] [review]
[gaia] sean2449:Bug_1136612 > mozilla-b2g:master

Crash report is using two kinds of UI, crash-dialog and system banner, under different containers, so our APIs have to be put in both crash report and system banner separately.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8571880 [details] [review]
[gaia] sean2449:Bug_1136612 > mozilla-b2g:master

Looks good to me. I had left some nits at PR. Thanks.

Comment 6

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8571880 [details] [review]
[gaia] sean2449:Bug_1136612 > mozilla-b2g:master

I saw my comments has been addressed. The patch looks great now. Thanks.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/579200c674a8614a48fb10a6c874ba9a5dbd8a85

gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=6096a3a64ddf