[Stingray] expose isVisible and focus API for bluetooth_transfer

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sungchiu, Assigned: sungchiu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
1. isVisible API: Determine whether this UI is visible or not, and return z-index.
2. focus API: Focus the default elementin this UI.
(Assignee)

Updated

3 years ago
No longer blocks: 1136589
Created attachment 8571701 [details] [review]
[gaia] sean2449:Bug_1136613 > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8571701 [details] [review]
[gaia] sean2449:Bug_1136613 > mozilla-b2g:master

API changed:
1. isVisible API: Determine whether this UI is visible, return boolean.
2. getOrder API: Return z-index of current UI.
3. focus: Focus the 'dialog-no' button ('dialog-yes' button may not be created in some condition).
Attachment #8571701 - Flags: review?(im)
(Assignee)

Updated

3 years ago
Assignee: nobody → suchiu
Comment on attachment 8571701 [details] [review]
[gaia] sean2449:Bug_1136613 > mozilla-b2g:master

Please focus back to app window while dialog is dismissed.
Attachment #8571701 - Flags: review?(im)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8571701 [details] [review]
[gaia] sean2449:Bug_1136613 > mozilla-b2g:master

Thanks for finding the bug, please help me to check again.
Attachment #8571701 - Flags: review?(im)
Comment on attachment 8571701 [details] [review]
[gaia] sean2449:Bug_1136613 > mozilla-b2g:master

Looks good to me. But please include the minor fix at notification handle of bluetooth transfer.
Attachment #8571701 - Flags: review?(im) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/b24c5fc2c945cfb4bab4ba037650c444c40bce80

gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=21098e4b30c7
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.