1136679 - adbhelper should support having its server being killed

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Alexandre Poirot [:ochameau]]

Today, if some local command, like adb kill-server, are shutting down adbhelper adb server, it ends up being broken. You then have to restart firefox or disable/enable the addon.
We should try to connect to the local adb server being run or restart a new server.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 14

I've been lazy and opened only one pull request,
hopefully, the modification are small enough to keep it clear!

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8569142 [details] [review]
Pull request 14

See PR.  I like the idea, but it doesn't entirely work on Mac because of device replug requirement.

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8569142 [details] [review]
Pull request 14

I tried to also improve mac support when we restart adb server,
but nothing seems to fix the odd failure.
I tried by restarting the server multiple times or when a device is reported as being "offline".

So I just did what you suggested, by reporting all devices as disconnected.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8569142 [details] [review]
Pull request 14

Cool, this version now cleans up properly on Mac.

Comment 5

[Alexandre Poirot [:ochameau]]

landed:
https://github.com/mozilla/adbhelper/commit/97f15a0990d6fc51f8b6f39ae4a7f39e73b60f2c