adbhelper should support having its server being killed

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
6 months ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Today, if some local command, like adb kill-server, are shutting down adbhelper adb server, it ends up being broken. You then have to restart firefox or disable/enable the addon.
We should try to connect to the local adb server being run or restart a new server.
(Assignee)

Comment 1

4 years ago
Created attachment 8569142 [details] [review]
Pull request 14

I've been lazy and opened only one pull request,
hopefully, the modification are small enough to keep it clear!
Assignee: nobody → poirot.alex
Attachment #8569142 - Flags: review?(jryans)
Comment on attachment 8569142 [details] [review]
Pull request 14

See PR.  I like the idea, but it doesn't entirely work on Mac because of device replug requirement.
Attachment #8569142 - Flags: review?(jryans)
(Assignee)

Comment 3

4 years ago
Comment on attachment 8569142 [details] [review]
Pull request 14

I tried to also improve mac support when we restart adb server,
but nothing seems to fix the odd failure.
I tried by restarting the server multiple times or when a device is reported as being "offline".

So I just did what you suggested, by reporting all devices as disconnected.
Attachment #8569142 - Flags: review?(jryans)
Comment on attachment 8569142 [details] [review]
Pull request 14

Cool, this version now cleans up properly on Mac.
Attachment #8569142 - Flags: review?(jryans) → review+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.