Closed Bug 1136693 Opened 5 years ago Closed 5 years ago

Request URL in Headers panel and info in Security panel aren't readable in dark theme

Categories

(DevTools :: Netmonitor, defect)

defect
Not set

Tracking

(firefox38+ fixed, firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox38 + fixed
firefox39 --- fixed

People

(Reporter: Kwan, Assigned: Kwan)

References

Details

(Keywords: regression)

Attachments

(2 files)

Regression caused by making them into textboxes (so they are selectable) in bug 1123952 and bug 1129055.  Screenshot to illustrate

Patch incoming
Ah, bummer. I didn't even think to switch themes when working on that. /o\
Attachment #8569153 - Flags: review?(vporof) → review+
Partial try run ongoing in https://treeherder.mozilla.org/#/jobs?repo=try&revision=150ff68993b9 (for another bug) but given that it's a one-line CSS colour change to fix a regression, I don't see a need for a full run.
If the one reading this due to checkin-needed disagrees, just let me know.
Keywords: checkin-needed
[Tracking Requested - why for this release]: degraded experience for web developers, several pieces of network debugging info are unreadable on dark theme, fix is very low risk
Keywords: leave-open
Sounds like a good plan to get this uplifted, please nominate once it's on central.
Comment on attachment 8569153 [details] [diff] [review]
Make the headers request URL and security panel info visible in the dark theme

Approval Request Comment
[Feature/regressing bug #]: bug 1123952 and bug 1129055

[User impact if declined]: Developer Edition (and eventually release) will be frustrating to use for developers, since several pieces of network debugging information will be unreadable if they are using the dark theme (the default on DevEdition?).

[Describe test coverage new/current, TreeHerder]: none

[Risks and why]: very low. One-line CSS colour change

[String/UUID change made/needed]: none
Attachment #8569153 - Flags: approval-mozilla-aurora?
Attachment #8569153 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: leave-open
Please don't use leave-open to track uplifts, it screws up our bug queries. Bug resolution tracks landing on mozilla-central, tracking flags track uplifts.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.