1136693 - Request URL in Headers panel and info in Security panel aren't readable in dark theme

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Ian Moody [:Kwan] (UTC+1)]

Attachment: screenshot of faint Request URL in dark theme

Regression caused by making them into textboxes (so they are selectable) in bug 1123952 and bug 1129055.  Screenshot to illustrate

Patch incoming

Comment 1

[Mike Taylor [:miketaylr]]

Ah, bummer. I didn't even think to switch themes when working on that. /o\

Comment 2

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Make the headers request URL and security panel info visible in the dark theme

Comment 3

[Ian Moody [:Kwan] (UTC+1)]

Partial try run ongoing in https://treeherder.mozilla.org/#/jobs?repo=try&revision=150ff68993b9 (for another bug) but given that it's a one-line CSS colour change to fix a regression, I don't see a need for a full run.
If the one reading this due to checkin-needed disagrees, just let me know.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/b4d8a42ad739

Comment 5

[Ian Moody [:Kwan] (UTC+1)]

[Tracking Requested - why for this release]: degraded experience for web developers, several pieces of network debugging info are unreadable on dark theme, fix is very low risk

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Sounds like a good plan to get this uplifted, please nominate once it's on central.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b4d8a42ad739

Comment 8

[Ian Moody [:Kwan] (UTC+1)]

Comment on attachment 8569153 [details] [diff] [review]
Make the headers request URL and security panel info visible in the dark theme

Approval Request Comment
[Feature/regressing bug #]: bug 1123952 and bug 1129055

[User impact if declined]: Developer Edition (and eventually release) will be frustrating to use for developers, since several pieces of network debugging information will be unreadable if they are using the dark theme (the default on DevEdition?).

[Describe test coverage new/current, TreeHerder]: none

[Risks and why]: very low. One-line CSS colour change

[String/UUID change made/needed]: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please don't use leave-open to track uplifts, it screws up our bug queries. Bug resolution tracks landing on mozilla-central, tracking flags track uplifts.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1f5f262bea13