1136698 - [Tests] Show Keyboard App after uninstallation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Alberto Pastor [:albertopq]]

Fix apps/keyboard/test/marionette/uninstallation_test.js in v2.2

Comment 2

[Julien Wajsberg [:julienw]]

I think this is either bug 1121274 or bug 1129541 (or both) to uplift.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1136698-fix-v2.2-test-kb > mozilla-b2g:v2.2

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8569211 [details] [review]
[gaia] albertopq:1136698-fix-v2.2-test-kb > mozilla-b2g:v2.2

I don't know if I'm the right person to look at this.

However I pointed some issues I see. Actually I don't understand why you change package.json... is it really necessary?

Can you try to simply cherry-pick the 3 patches from bug 1121274? If yes and it works, you can simply say it in bug 1121274.

Comment 5

[Alberto Pastor [:albertopq]]

Those patches don't apply at all to v2.2. We are not using systemInputMgmt in the v2.2 version, for example. Replacing the current master test into v2.2 results on the test failing with the same error. After updating marionnete-client (through packages.json) everything started working.

Comment 6

[Julien Wajsberg [:julienw]]

OK; then I think you'll need to update gaia-node-modules on a v2.2 branch, so that you can change the commit hash in gaia_node_modules.revision.

See https://github.com/mozilla-b2g/gaia-node-modules/ for more information, there is a README that explains properly what to do.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia-node-modules] albertopq:1136698-fix-v2.2-tests > mozilla-b2g:v2.2

Comment 8

[Alberto Pastor [:albertopq]]

Comment on attachment 8569211 [details] [review]
[gaia] albertopq:1136698-fix-v2.2-test-kb > mozilla-b2g:v2.2

Replacing tests with the ones in master, and updating marionnete-client module.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8569211 [details] [review]
[gaia] albertopq:1136698-fix-v2.2-test-kb > mozilla-b2g:v2.2

Sounds good to me, as long as it's more green than before :) Thanks for updating the tests.

Comment 10

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 11

[Alberto Pastor [:albertopq]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/eb6a5ac9081d3962198e0f4520b0743d716d7a27