[Tests] Show Keyboard App after uninstallation

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: albertopq, Assigned: albertopq)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Fix apps/keyboard/test/marionette/uninstallation_test.js in v2.2
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1121274
I think this is either bug 1121274 or bug 1129541 (or both) to uplift.
(Assignee)

Updated

3 years ago
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(Assignee)

Updated

3 years ago
Assignee: nobody → apastor
Created attachment 8569211 [details] [review]
[gaia] albertopq:1136698-fix-v2.2-test-kb > mozilla-b2g:v2.2
(Assignee)

Updated

3 years ago
Attachment #8569211 - Flags: review?(felash)
Comment on attachment 8569211 [details] [review]
[gaia] albertopq:1136698-fix-v2.2-test-kb > mozilla-b2g:v2.2

I don't know if I'm the right person to look at this.

However I pointed some issues I see. Actually I don't understand why you change package.json... is it really necessary?

Can you try to simply cherry-pick the 3 patches from bug 1121274? If yes and it works, you can simply say it in bug 1121274.
Attachment #8569211 - Flags: review?(felash)
(Assignee)

Comment 5

3 years ago
Those patches don't apply at all to v2.2. We are not using systemInputMgmt in the v2.2 version, for example. Replacing the current master test into v2.2 results on the test failing with the same error. After updating marionnete-client (through packages.json) everything started working.
OK; then I think you'll need to update gaia-node-modules on a v2.2 branch, so that you can change the commit hash in gaia_node_modules.revision.

See https://github.com/mozilla-b2g/gaia-node-modules/ for more information, there is a README that explains properly what to do.
Created attachment 8569871 [details] [review]
[gaia-node-modules] albertopq:1136698-fix-v2.2-tests > mozilla-b2g:v2.2
(Assignee)

Comment 8

3 years ago
Comment on attachment 8569211 [details] [review]
[gaia] albertopq:1136698-fix-v2.2-test-kb > mozilla-b2g:v2.2

Replacing tests with the ones in master, and updating marionnete-client module.
Attachment #8569211 - Flags: review?(kgrandon)
Comment on attachment 8569211 [details] [review]
[gaia] albertopq:1136698-fix-v2.2-test-kb > mozilla-b2g:v2.2

Sounds good to me, as long as it's more green than before :) Thanks for updating the tests.
Attachment #8569211 - Flags: review?(kgrandon) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
(Assignee)

Comment 11

3 years ago
v2.2: https://github.com/mozilla-b2g/gaia/commit/eb6a5ac9081d3962198e0f4520b0743d716d7a27
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.