1136803 - Removing a touch event listener from a window doesn't remove the force-dtc flag on the layer

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

While checking Greg's patch on bug 1130016 I noticed that even though his code removed the touchstart listener, the force-dtc flag still persisted on the layer. This happens because the layer at [1] is reused across paints, and we only set the override flag but we never clear it. This is an error in the refactoring patch I landed for bug 1131840.

[1] http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.cpp?rev=96d7198bec0a#4171

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8569318 [details] [diff] [review]
Patch

Review of attachment 8569318 [details] [diff] [review]:
-----------------------------------------------------------------

Tricky!

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e8707d9962d

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6e8707d9962d

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8569318 [details] [diff] [review]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): regression from bug 1131840
User impact if declined: in some cases the APZ will perform less well than it should, because we weren't properly tracking removal of touch listeners from the DOM. Honestly the impact of this is low unless we also land bug 1116579 but the risk is also quite low so requesting uplift anyway.
Testing completed: locally
Risk to taking this patch (and alternatives if risky): very low risk, just fixes a refactoring error.
String or UUID changes made by this patch: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2caa69cc467c