1136810 - [heartbeat] UnboundLocalError: local variable 'showdata' referenced before assignment

Status: RESOLVED FIXED

(Input Graveyard :: Backend, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Saw a bunch of errors from an analyzer looking at hb data.

Needs looking into.

Traceback:

Internal Server Error: /en-US/analytics/hbdata/16617
Traceback (most recent call last):
  File "/data/www/input.mozilla.org/input/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/data/www/input.mozilla.org/venv/lib/python2.7/site-packages/newrelic-2.38.0.31/newrelic/hooks/framework_django.py", line 497, in wrapper
    return wrapped(*args, **kwargs)
  File "/data/www/input.mozilla.org/input/fjord/base/utils.py", line 432, in _wrapped_view
    return fun(request, *args, **kwargs)
  File "/data/www/input.mozilla.org/input/vendor/src/django/django/contrib/auth/decorators.py", line 21, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/data/www/input.mozilla.org/input/fjord/analytics/analyzer_views.py", line 111, in hb_data
    'showdata': showdata,
UnboundLocalError: local variable 'showdata' referenced before assignment

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to look into now.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/499

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/fjord/commit/8f3b8e8f137ac595978d2ed8005648f83da09424

Will push next deploy.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed this to prod just now. This looks fixed.