Composer freezes when removing multiple ol or ul tags.

VERIFIED FIXED in mozilla0.9.9

Status

()

Core
Editor
--
critical
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: TucsonTester1, Assigned: Joe Francis)

Tracking

({hang, perf})

Trunk
mozilla0.9.9
hang, perf
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: EDITORBASE+; fixinhand; need r=)

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6+)
Gecko/20011203 Netscape6/6.1b1
BuildID:    2001120303

When using the toolbar to remove multiple indented bulleted or number lines,
Composer freezes.

Reproducible: Always
Steps to Reproduce:
1. Launch Composer
2. Enter 10 letters of text
3. Click on the bullet or or numbered list button on the toolbar
4. Click on indent twenty-five times.
5. Click on the bullet or number list button on the toolbar (the same one you
clicked in step 3).

Actual Results:  Composer will freeze.  An end task will need to be done to
break out of it.

Expected Results:  Composer should not freeze when removing the tags.

I've had it freeze with as few as twenty indents.  With between 15 and 20
indents, it will hang for a bit, but recover.  This was reproduced on two other
machines, one using 98 (not SE), and the other using 95 OSR2.

Updated

16 years ago
Keywords: hang

Comment 1

16 years ago
Confirmed with 2001-12-05-04 under W2K
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

16 years ago
I consulted with joe on this one, definitely this needs looking at. I can
reproduce on Windows NT, suspect it is cross platform (damn that Microsoft, I
can't use XP now cause they stole the term from us). I also observed that around
15 characters, I go *totally* glacial when hitting the OL button (or the UL
button) to undo the list. And I lock up at twenty. We must be iterating past
some boundary or something, I'm trying hard to think of an algorithm that would
slow down so exponentially like this one is.
Assignee: syd → jfrancis
Component: Editor: Composer → Editor: Core
Keywords: perf
Whiteboard: EDITORBASE
(Assignee)

Comment 3

16 years ago
Recur                     sion?
     Recur            sion
          Recur   sion
               ...
                .
                .
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
(Reporter)

Comment 4

16 years ago
This problem as mentioned in Comment 2 is also occuring on Mac OS X build
2001121004 using the steps specified by the reporter.
(Reporter)

Comment 5

16 years ago
changing platform/OS to all as mentioned in comment 4
OS: Windows 2000 → All
Hardware: PC → All
(Assignee)

Comment 6

16 years ago
pushing off 098 to 099
Target Milestone: mozilla0.9.8 → mozilla0.9.9
(Assignee)

Comment 7

16 years ago
Already spent half a day on this.  It's fairly complex - the post processing
code is the culprit, and I suspect the editor's concept of the range of the
document that has changed.  Estimating 2 days
Whiteboard: EDITORBASE → EDITORBASE; 2 days

Comment 8

16 years ago
lists and hangs, oh my! plussing
Whiteboard: EDITORBASE; 2 days → EDITORBASE+; 2 days
(Assignee)

Comment 9

16 years ago
attaching patch for this.  patch also includes bug 120000 patch.  I'd like to
land them together anyway.
Whiteboard: EDITORBASE+; 2 days → EDITORBASE+; fixinhand; need r=,sr=
(Assignee)

Comment 10

16 years ago
Created attachment 67606 [details] [diff] [review]
diffs to editor/libeditor

Updated

16 years ago
Keywords: nsbeta1+

Comment 11

16 years ago
Comment on attachment 67606 [details] [diff] [review]
diffs to editor/libeditor

sr=kin@netscape.com

With the changes we disucssed.
Attachment #67606 - Flags: superreview+

Updated

16 years ago
Whiteboard: EDITORBASE+; fixinhand; need r=,sr= → EDITORBASE+; fixinhand; need r=
(Assignee)

Comment 12

16 years ago
fix landed on trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 13

16 years ago
Verified fixed on trunk build 02-08.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.