SiteTableViewController cleanup

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
SiteTableViewController is still coupled to HomePanelDelegate, which is a bit strange considering SiteTableViewController doesn't even use the delegate it owns. I think we can clean this up by:
* Moving SiteTableViewController out of Home/ and into Widgets/
* Removing the unused HomePanelDelegate from SiteTableViewController
* Making home panels subclass SiteTableViewController directly, implement HomePanel directly, and own their own delegates
(Assignee)

Comment 1

3 years ago
Created attachment 8569449 [details] [review]
Pull request
Attachment #8569449 - Flags: review?(wjohnston)
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
Comment on attachment 8569449 [details] [review]
Pull request

I don't really understand the desire to keep the Search controller delegate separate from the home ones. They're basically the same interface with slightly different method names.
Attachment #8569449 - Flags: review?(wjohnston) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.