Closed
Bug 1136976
Opened 10 years ago
Closed 10 years ago
Set MLS geolocation for Firefox desktop to non-release only
Categories
(Core :: DOM: Geolocation, defect)
Core
DOM: Geolocation
Tracking
()
RESOLVED
FIXED
mozilla39
People
(Reporter: garvan, Assigned: garvan)
References
Details
Attachments
(1 file, 1 obsolete file)
1.18 KB,
patch
|
garvan
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
wrap the changes in Bug #1121862 to non-release only
Attachment #8569968 -
Flags: review?(cpeterson)
Comment 2•10 years ago
|
||
Comment on attachment 8569968 [details] [diff] [review] set use MLS to nightly/auroroa in firefox.js and metro.js Review of attachment 8569968 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8569968 -
Flags: review?(cpeterson) → review+
Comment 3•10 years ago
|
||
FWIW you don't need to bother with the metro.js change, it's unused and will be removed by bug 1039866.
Updated•10 years ago
|
Attachment #8569968 -
Flags: review+
Comment 4•10 years ago
|
||
We need to uplift this change to Aurora too, right?
status-firefox38:
--- → affected
status-firefox39:
--- → affected
tracking-firefox38:
--- → +
tracking-firefox39:
--- → +
Removed metro.js. Approval Request Comment [Feature/regressing bug #]: Relates to bug 1121862, in anticipation of a change of geolocation service the URL was changed to point to MLS. This change has been postponed. [User impact if declined]: Wrong geoloc. service. [Describe test coverage new/current, TreeHerder]: None. [Risks and why]: Not prepared to make MLS switch at this time. [String/UUID change made/needed]: None
Attachment #8569968 -
Attachment is obsolete: true
Attachment #8570502 -
Flags: review+
Attachment #8570502 -
Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/928ec762c672
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Updated•10 years ago
|
Attachment #8570502 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•