Add macosx64-mulet and win32-mulet to trychooser

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
3 years ago
7 months ago

People

(Reporter: mshal, Assigned: mshal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
These builds run on mozilla-central, but not on try. I'd like to make sure I don't break them in bug 1132123.
(Assignee)

Comment 1

3 years ago
Created attachment 8569506 [details] [diff] [review]
trychooser-mulet

I think this is all that's needed based on the diff from bug 1046377, but I've not touched trychooser before. Please let me know if I'm missing anything.
Assignee: nobody → mshal
Attachment #8569506 - Flags: review?(emorley)

Comment 2

3 years ago
Comment on attachment 8569506 [details] [diff] [review]
trychooser-mulet

Review of attachment 8569506 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm with those fixed.
I'd test locally if you haven't already, just to be sure :-) (I didn't)

::: trychooser/tryload.js
@@ +89,5 @@
>          totalTestLoad["macosx64"] = Math.max(
>                                        load_try_test["mac10.6"] + load_nontry_test["mac10.6"],
>                                        load_try_test["mac10.8"] + load_nontry_test["mac10.8"],
>                                        load_try_test["mac10.10"] + load_nontry_test["mac10.10"]);
> +        totalTestLoad["macosx64-mulet"] = totalTestLoad["macosx64"]

Missing semicolon

@@ +94,5 @@
>          totalTestLoad["win32"] = Math.max(
>                                     load_try_test["winxp-ix"] + load_nontry_test["winxp-ix"],
>                                     load_try_test["win7-ix"] + load_nontry_test["win7-ix"],
>                                     load_try_test["win8-ix"] + load_nontry_test["win8-ix"]);
> +        totalTestLoad["win32-mulet"] = totalTestLoad["win32"]

Missing semicolon
Attachment #8569506 - Flags: review?(emorley) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8569879 [details] [diff] [review]
trychooser-mulet

Good catch! Now with semicolons, r+ carried forward. It looks ok to me when I load it up locally...
Attachment #8569506 - Attachment is obsolete: true
Attachment #8569879 - Flags: review+

Comment 4

3 years ago
land away; I can deploy it if you don't have access :-)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8569879 [details] [diff] [review]
trychooser-mulet

https://hg.mozilla.org/build/tools/rev/a5abf8ee2d5e

If you can deploy it, that would be great!
Attachment #8569879 - Flags: checked-in+

Comment 6

3 years ago
Deployed :-)
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Blocks: 1112994
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.